emit a few more events on proxied accessibles for atk

RESOLVED FIXED in Firefox 41

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8604868 [details] [diff] [review]
emit a few more events on proxied accessibles for atk
Attachment #8604868 - Flags: review?(dbolter)
Comment on attachment 8604868 [details] [diff] [review]
emit a few more events on proxied accessibles for atk

Review of attachment 8604868 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe something more descriptive for checkin like "Emit a some document and menupopup events on proxied accessibles for atk" would be lovelier.

::: accessible/atk/AccessibleWrap.cpp
@@ +1354,5 @@
>  {
>    AtkObject* wrapper = GetWrapperFor(aTarget);
> +
> +  switch (aEventType) {
> +  case nsIAccessibleEvent::EVENT_FOCUS:

nit: this whole switch body should be indented 2 more spaces.
Attachment #8604868 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

3 years ago
> ::: accessible/atk/AccessibleWrap.cpp
> @@ +1354,5 @@
> >  {
> >    AtkObject* wrapper = GetWrapperFor(aTarget);
> > +
> > +  switch (aEventType) {
> > +  case nsIAccessibleEvent::EVENT_FOCUS:
> 
> nit: this whole switch body should be indented 2 more spaces.

that file doesn't seem to agree with itself on if case labels should be indented or not, so it wasn't totally unintentional.
https://hg.mozilla.org/mozilla-central/rev/06b840460921
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.