Closed Bug 1164194 Opened 9 years ago Closed 9 years ago

Build Gaia with |GAIA_DISTRIBUTION_DIR=distros/spark|

Categories

(Taskcluster :: General, defect, P1)

Product:
Taskcluster
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: wcosta)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

MozReview Request: Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt
40 bytes, text/x-review-board-request
garndt
: review+
Details
MozReview Request: Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt
40 bytes, text/x-review-board-request
garndt
: review+
Details 
When bug 1159411 and bug 1158367 land, we'll have moved all of our build infrastructure out of the lightsaber build repo, and into Gaia proper. However, we'll have to build our nightly builds with the |GAIA_DISTRIBUTION_DIR=`pwd`/distros/spark| env var set.

We should continue to build some images without this env var, so what I propose is that our existing images continue to be built-as is, but all of the new tasks that we added starting from the beginning of the Spark project have this new env var added.

At the same time, if we're still using |LIGHTSABER=1| or anything from the lightsaber repo, we can stop using these entirely.
Wander, do you have any thoughts on this? Can you take it? Thanks.
Flags: needinfo?(wcosta)
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)
> Wander, do you have any thoughts on this? Can you take it? Thanks.

It is just a matter of adding a new env var to the build config file, like here https://hg.mozilla.org/build/mozharness/file/d2e22f9a7afc/configs/b2g/taskcluster-lightsaber-nightly.py#l18

We just need to know what `pwd` exactly is (current build dir, gaia dir...)
Flags: needinfo?(wcosta)
(In reply to Wander Lairson Costa [:wcosta] from comment #2)
> (In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)
> > Wander, do you have any thoughts on this? Can you take it? Thanks.
> 
> It is just a matter of adding a new env var to the build config file, like
> here
> https://hg.mozilla.org/build/mozharness/file/d2e22f9a7afc/configs/b2g/
> taskcluster-lightsaber-nightly.py#l18
> 
> We just need to know what `pwd` exactly is (current build dir, gaia dir...)

`pwd` is the Gaia directory. It would be preferable if we could use relative instead of absolute paths here. Dale, do you know if we can do that somehow?
Flags: needinfo?(dale)
See Also: → 1164212
We can probably fix it to normalise the path, this trips up quite a few people, filed http://www.bzlite.com/bug/1167858
Flags: needinfo?(dale)
Depends on: 1167858
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
Bug 1167858 was invalid. We can just use |GAIA_DISTRIBUTION_DIR=distros/spark make| instead. We should wait for bug 1168828 and bug 1169353 to be fixed before going ahead with this, though.
Depends on: 1168828, 1169353
Summary: Build Gaia with |GAIA_DISTRIBUTION_DIR=`pwd`/distros/spark| → Build Gaia with |GAIA_DISTRIBUTION_DIR=distros/spark|
Depends on: 1170350
No longer depends on: 1170350
Wander, all the dependencies for this bug have landed, so we can go ahead with this.
Flags: needinfo?(wcosta)
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #6)
> Wander, all the dependencies for this bug have landed, so we can go ahead
> with this.

Yep, I am testing things right now :)
Flags: needinfo?(wcosta)
Testing : https://tools.taskcluster.net/task-inspector/#PHh2hwLHSe-5h2g8ERbBVA/0

I think there's a few bugs that might end up getting resolved by this build.
Not sure why/how.  We'll need to do a bunch of retesting.  Some of the polish bug might be resolved?

I say ship it so we can find out what smoke test is like tomorrow for dogfood branch.
Spoke with Doug about this, he mentioned that we should have gotten the colorful rocketship background.  When I did this on my own build machine, I did get that. 

I think the gaia repo needs to be updated for task cluster?  I think wander was making a new dogfood build?
Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt

Spark has been integrated into main gaia.
Attachment #8616012 - Flags: review?(garndt)
Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

Spark now can be built from main gaia repository, so we don't need to
keep specific spark build scripts. The small differences are now handled
through environment variables.
Attachment #8616020 - Flags: review?(garndt)
Attachment #8616020 - Flags: feedback?(nhirata.bugzilla)
Attachment #8616020 - Flags: review?(garndt) → review+
Comment on attachment 8616020 [details]
MozReview Request: Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

https://reviewboard.mozilla.org/r/10399/#review9103

Ship It!
Comment on attachment 8616012 [details]
MozReview Request: Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt

https://reviewboard.mozilla.org/r/10391/#review9105

Ship It!
Attachment #8616012 - Flags: review?(garndt) → review+
r+ with verifying with RyanVM the distinction between nightly and OTA for mozharness script names.  Just want to make sure as I know there were confusion around it since we don't really have nightly builds in TC right now.
Comment on attachment 8616020 [details]
MozReview Request: Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

I defer to garndt's judgement.  I'm not sure if I understand all the changes.
Attachment #8616020 - Flags: feedback?(nhirata.bugzilla) → feedback+
Comment on attachment 8616020 [details]
MozReview Request: Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

Spark now can be built from main gaia repository, so we don't need to
keep specific spark build scripts. The small differences are now handled
through environment variables.
Attachment #8616020 - Flags: review?(garndt)
Attachment #8616020 - Flags: review+
Attachment #8616020 - Flags: feedback+
Attachment #8616012 - Flags: review+ → review?(garndt)
Comment on attachment 8616012 [details]
MozReview Request: Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt

Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt

Spark has been integrated into main gaia.
Top link works as expected when full flashed:
https://tools.taskcluster.net/task-inspector/#PETOH48cTy2sycY2uopsLA/

I filed bug 1172194 in regards to the new background not being a part of the set when OTAing to this version.
Comment on attachment 8616020 [details]
MozReview Request: Bug 1164194: Get rid of all spark specific files. r=garndt a=garndt

https://reviewboard.mozilla.org/r/10399/#review9177

Ship It!
Attachment #8616020 - Flags: review?(garndt) → review+
Comment on attachment 8616012 [details]
MozReview Request: Bug 1164194: Move spark to main gaia repo. r=garndt a=garndt

https://reviewboard.mozilla.org/r/10391/#review9173

Ship It!

::: configs/b2g/taskcluster-spark-dogfood.py:19
(Diff revision 2)
>          "DOGFOOD": "1",

I'm not sure if it could be done in MH, but it looks liek the only difference between this config and the spark-ota config is DOGFOOD=1...wonder if we would just grab the OTA config and merge in that one option.
Attachment #8616012 - Flags: review?(garndt) → review+
https://hg.mozilla.org/mozilla-central/rev/40e2afebddd6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
status-firefox41: fixed → ---
Component: TaskCluster → General
Product: Testing → Taskcluster
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
See Also: → 1202888
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: