1164209 - Treeherder flashes on load when switching from Perfherder logo-menu

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

We added access between Treeherder and Perfherder in 1162706, via drop down menus off their respective top left brand logos.

When switching from Perfherder > Treeherder, Treeherder 'flashes' or partly loads and only then fully loads. I didn't observe this in local testing for bug 1162706.

Step to reproduce:
o https://treeherder.allizom.org
o Treeherder>Perfherder (navigate to Perf via the top left logo menu)
o Perfherder>Treeherder (navigate back via the same in Perf)

Expected results:
o A single page load similar to loading https://treeherder.allizom.org directly.

Observed results:
o Treeherder loads the navbar minus its job content, then the page goes blank and it re-loads for real.

Comment 1

[Jonathan French (:jfrench)]

Based on live simulations on stage, I could mimic the behavior by feeding the url the current "/#" route when on Perf.

So I think the fix is to adjust the route from "/#" to either "/#/" or "/" (both of which seem to also play nice in vagrant) so I'll go with the latter and we can try it on stage.

Comment 2

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#525

Please see above tweak PR for review :)

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8605043 [details] [review]
treeherder-ui-PR#525

Thanks :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/97db1f58911e283ec118bf0d3f088359daa0418c
Bug 1164209 - Fix page flash when UI switching from Perf to Treeherder

Comment 5

[Jonathan French (:jfrench)]

Marking fixed per above merge. I'll verify on the next push to stage/prod.

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7a6eed77c5705b8bdf08ba8b36e24dbfcd225ce9
Bug 1164209 - Fix page flash when UI switching from Perf to Treeherder