[gcli] Allow the "restart" command to restart into Safe Mode

RESOLVED FIXED in Firefox 42

Status

()

Firefox
Developer Tools: Graphic Commandline and Toolbar
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: strugee, Assigned: Johan K. Jensen)

Tracking

41 Branch
Firefox 42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
GCLI's "restart" command should have an additional boolean parameter controlling whether the browser should restart into Safe Mode.
(Assignee)

Comment 1

3 years ago
Created attachment 8632528 [details] [diff] [review]
bug1164226_restart_safemode__johankj.patch

This patch changes the restart-gcli-command from `restart <nocache>` to `restart [--nocache] [--safemode]`.
If the safemode-flag is enabled the command will restart the app into Safe Mode.
Attachment #8632528 - Flags: review?(jryans)
Comment on attachment 8632528 [details] [diff] [review]
bug1164226_restart_safemode__johankj.patch

Review of attachment 8632528 [details] [diff] [review]:
-----------------------------------------------------------------

Great, looks good to me!
Attachment #8632528 - Flags: review?(jryans) → review+
Johan, would you like to push this one to Try yourself?  You'll need to request access[1] first.

[1]: https://www.mozilla.org/en-US/about/governance/policies/commit/
Assignee: nobody → jj
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(jj)
(Assignee)

Comment 4

2 years ago
If the test-suite is correct, everything looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=964fa5ee2aaf
Flags: needinfo?(jj) → needinfo?(jryans)
Yes, it looks safe to me!
Flags: needinfo?(jryans)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/8b5c3d8e2101
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8b5c3d8e2101
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.