1164226 - [gcli] Allow the "restart" command to restart into Safe Mode

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[AJ Jordan [:strugee] (he/they)]

GCLI's "restart" command should have an additional boolean parameter controlling whether the browser should restart into Safe Mode.

Comment 1

[Johan K. Jensen :johankj]

Attachment: bug1164226_restart_safemode__johankj.patch

This patch changes the restart-gcli-command from `restart <nocache>` to `restart [--nocache] [--safemode]`.
If the safemode-flag is enabled the command will restart the app into Safe Mode.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8632528 [details] [diff] [review]
bug1164226_restart_safemode__johankj.patch

Review of attachment 8632528 [details] [diff] [review]:
-----------------------------------------------------------------

Great, looks good to me!

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Johan, would you like to push this one to Try yourself?  You'll need to request access[1] first.

[1]: https://www.mozilla.org/en-US/about/governance/policies/commit/

Comment 4

[Johan K. Jensen :johankj]

If the test-suite is correct, everything looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=964fa5ee2aaf

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, it looks safe to me!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8b5c3d8e2101

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b5c3d8e2101