Provide long-press actions as accessibility custom actions

RESOLVED FIXED

Status

()

Firefox for iOS
Browser
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Boris Dušek, Assigned: Boris Dušek)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Asking a VoiceOver user for a long-press (with VoiceOver achievable by double-tapping-and-holding) is not providing the best (“VoiceOver native”) user experience for the specific task. What availability of long-press on a button for sighted people really means is that there is more than one thing, action achievable with that button. VoiceOver has a native concept for this called accessibility custom actions.

So it is natural to provide such action as accessibility custom actions for VoiceOver. E.g. instead of long-pressing the Reader Mode button for adding item to reading list, which would be communicated to VoiceOver user by an explicit accessibility hint like “Double-tap and hold to add item to reading list”, `accessibilityCustomAction` should be added to the button which is called “Add to Reading List”. No hint is then needed to be set on the button, as VoiceOver provides a hint itself that custom actions are available on the button (even when VoiceOver hints have been turned off by the user). The user then can comfortably choose the alternative action by swiping up/down.

On the location label, there are 3 actions presented as UIAlerts after long-press, for VoiceOver best would be to have them available all as 3 custom actions.
(Assignee)

Comment 1

3 years ago
Created attachment 8609868 [details] [review]
Pull Request
Attachment #8609868 - Flags: review?(bnicholson)
Comment on attachment 8609868 [details] [review]
Pull Request

Looks pretty good overall. Left some comments in the PR.
Attachment #8609868 - Flags: review?(bnicholson) → feedback+
(Assignee)

Comment 3

3 years ago
Thanks, sorry but I will be able to start looking at this again only on Tuesday, June 2 and forward.
No problem, just clearing my review request :)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8609868 [details] [review]
Pull Request

I addressed all review comments (save for one) - please take a look at the latest comment on GitHub and hopefully merge. Thanks.
Attachment #8609868 - Flags: review?(sarentz)
Comment on attachment 8609868 [details] [review]
Pull Request

Taking these reviews since st3fan is buried.
Attachment #8609868 - Flags: review?(sarentz)
Attachment #8609868 - Flags: review?(bnicholson)
Attachment #8609868 - Flags: feedback+
Comment on attachment 8609868 [details] [review]
Pull Request

A few minor proposed changes in the PR; r=me with those addressed.
Attachment #8609868 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 8

3 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #7)
> A few minor proposed changes in the PR; r=me with those addressed.

:bnicholson I addressed all the comments you had. A merge? :-)

(P.S.: hope the needinfo is OK - actually hoping it is useful: if not, please tell me)
Flags: needinfo?(bnicholson)
NEEDINFO is fine. Thanks a ton for all of your contributions, as usual!

https://github.com/mozilla/firefox-ios/commit/97b0f26a43c81a9dde33a4648aa6c70ffa17fe9b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(bnicholson)
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
See Also: → bug 1191059
You need to log in before you can comment on or make changes to this bug.