1164236 - Intro View Accessibility

Status: NEW

(Firefox for iOS :: General, defect)

Description

[Boris Dušek]

- "Back"/"Forward" should be labeled as "Previous"/"Next"
- After pressing the arrow, VoiceOver cursor should move to the text of the item (not stay on the arrow).

Comment 1

[Boris Dušek]

The intro wizard has changed significantly so the previous assessment of its accessibility is no longer valid.

Right now, there are these accessibility issues:

- no way to go to the next/previous screen - there are no longer the Next/Previous buttons, scrolling gestures do not work; only by a workaround - double-press-and-hold, then flick right/left - scrolls accordingly

- the adjustable page indicator cannot be adjusted

- images are not conveyed to accessibility (no descriptions) - e.g. the first image contains a hint where the tabs button is with respect to other UI elements, and that it contains a number of tabs. This is a useful "101"-type information that should be conveyed to a VoiceOver user too

- "Start Browsing" should be invokable by accessibility escape gesture

Comment 2

[Boris Dušek]

Attachment: Pull Request

The bug will not be fixed after integrating this first PR. (That will only happen after integrating a second PR which I anticipate in 1-2 weeks.) So please do not close this bug after merging this first PR.

Comment 3

[Brian Nicholson (:bnicholson)]

It's usually a good idea to open a separate bug per pull request; I would have suggested creating a separate bug specifically for landing the early strings (this helps reduce clutter and avoid confusion). No big deal though. Thanks!

https://github.com/mozilla/firefox-ios/commit/13770619e9b9aae4da604eff56f360c23aeee44a

Comment 4

[Marco Zehe (:MarcoZ)]

What prevents this from landing?

Comment 5

[Boris Dušek]

I haven't finished it yet (though I have some intermediate state in my git on my laptop). The original pull request was just for translatable strings, with actual work to follow in another pull request.

Comment 6

[Stephan Leroux [:sleroux]]

Hey Boris,

I noticed that there are a couple of new strings added in this patch:

https://github.com/mozilla/firefox-ios/commit/13770619e9b9aae4da604eff56f360c23aeee44a

Do you know if these made it onto master? We're currently string frozen for 1.0 so any additional strings will unfortunately need to be added to the 1.1 release.

Comment 7

[Boris Dušek]

Hello Stephan,

yes, the strings luckily made it, the only thing left now is to finish the actual code :-)

Comment 8

[Stephan Leroux [:sleroux]]

Awesome :) Thanks for all the hard work on the accessibility stuff btw!

Comment 9

[Boris Dušek]

(In reply to Stephan Leroux [:sleroux] from comment #8)
> Thanks for all the hard work on the accessibility stuff btw!

Thanks :-)

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jeevans, could you have a look please?
For more information, please visit auto_nag documentation.