Closed Bug 1164278 Opened 9 years ago Closed 9 years ago

Fx Family global nav iteration: separate browsers from Fx OS

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: malexis, Assigned: jpetto)

Details

(Whiteboard: [kb=1747294] )

Attachments

(4 files)

Notes from check-in: https://etherpad.mozilla.org/firefox-family-weekly-status-2015-05-12

Rough schedule

- internal team review late week of may 18
- first review with mem week of may 25 (jen on pto may 26)
- review with mem early week of june 1 (creative team may be in sf)
- live week of july 6 or june 8 or june 29?
Whiteboard: [kb=1747294]
Next Steps from status meeting today:

- Ty to send final concept mockups to MEM today
- Once approved, Ty hands-off to Jon for implementation
- Jon will target having PR ready by Thursday 
- Launch this week or after Whistler depending on how long implementation and code review takes
Currently up on demo4:

https://www-demo4.allizom.org/en-US/firefox/os/2.0/ (and on all fx family nav pages)

Will submit a PR tomorrow if there are no additional tweaks.
Attached file GitHub PR
The desktop state (and the disjointedness between the 2 vertical lines in the main and secondary nav) is making me think we should go with the dotted vertical line that doesn't touch the horizontal line below instead.

Ty - Could you please share that option with Jon?

I'll tell MEM what we have run into and that we are trying the dotted line instead.  

Jon - Could you please send me a screenshot of the dotted line version (on the desktop page) from your local (after you chat with Ty) and I can share both with MEM?

Ping me on IRC tomorrow if anyone has questions!
Flags: needinfo?(tflanagan)
Flags: needinfo?(malexis)
Flags: needinfo?(jon)
(In reply to Jennifer Bertsch [:jbertsch] from comment #4)
> Created attachment 8620743 [details]
> vertical line dis-harmony on desktop state
> 
> The desktop state (and the disjointedness between the 2 vertical lines in
> the main and secondary nav) is making me think we should go with the dotted
> vertical line that doesn't touch the horizontal line below instead.

Seeing it on the demo server, I agree. We have a lot of lines going on and this feels like it's competing. The dotted line will actually help it stand out more.

Good catch, Jen.
Good catch Jen. Lets go with the dotted line.
Flags: needinfo?(tflanagan)
Here is the mockup with the dotted line separator
Thanks, Ty.

I felt jpetto had a great suggestion too (making the top line solid and the bottom line dotted). Have you two reviewed that?

I want to show whatever the new version is to MEM on the Desktop page so that she understand why we made the change.
Flags: needinfo?(tflanagan)
I avoided the solid line on the top since the top portion of the nav should have a more open feel versus being connected to the top of the page.

If anything, we could try the dotted line within the subnav bar though to keep consistency with the use of separators.
Flags: needinfo?(tflanagan)
Sample with dotted lines in both navs:

https://www-demo4.allizom.org/en-US/firefox/desktop/
Flags: needinfo?(jon)
(In reply to Jon Petto [:jpetto] from comment #11)
> Sample with dotted lines in both navs:
> 
> https://www-demo4.allizom.org/en-US/firefox/desktop/

Jen, let us know if we have sign-off to launch with what is on demo4
Flags: needinfo?(malexis) → needinfo?(jbertsch)
Hi Jon and Mike-

Ty proposed a new version of the nav to solve the "separate OS from the browser" problem.  I reviewed it with Holly and Tim.  Pending any concerns from Jon, we'd like to move forward with this solution:
https://drive.google.com/file/d/0Bz3C356pEHIcWldnOUh1WHRxa0xnNGhHSVQwS2FvbHdYSTZB/view?usp=sharing

Jon - Please let us know if you have any concerns!

If not, could we get this live in the first two weeks of July?

Thx,
Jen
Flags: needinfo?(jbertsch)
Hi Jon-

Per our workweek conversation today, let's turn off the hover state when we make the update in comment #13 next week.

Thx,
Jen
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/803dbe2168af81aaca04672fbcd9052a57c5509d
Bug 1164278. Fx Family nav FxOS distinction.

https://github.com/mozilla/bedrock/commit/340c093057992778a37f13ed54e30d7d08f2e6b8
Merge pull request #3053 from jpetto/bug-1164278-fx-fam-nav-fxos-distinction

Bug 1164278. Fx Family nav FxOS distinction.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: