1164289 - reverting to prior rules and releases is busted

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[hwine]

When attempting to disable updates to 38.0, I could not revert to the prior rule from the history view.

When I attempted that, I got a series of "are you sure" alerts. Clicking "yes" visibly dismissed the alert, only to be replaced by a new instance of the same alert.

Comment 1

[[e-mail] (:bhearsum)]

I repro'ed this in dev. The response the UI gets back is a 400 which says "no change_id". The request payload is:
{"change_id":512,"csrf_token":"xxxxxxxxxxxxxxxxxxxx"}

...so something is messed up, clearly. It wouldn't shock me if one or both of bug 1163170 or bug 1129149 are rooted in the same issue. Seems like there's some general wonkiness around the history UI.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Saw this today too. Any idea which bug you mean instead of bug 1163170 ?

Comment 3

[[e-mail] (:bhearsum)]

I rediscovered this bug today, and found a fix. I'll post it once I get a regression test or two written.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: look for json data instead of basic form data

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/2d6aa83a7ee90232c8054fe0b6fe31699ef6d4af
bug 1164289: reverting to prior rules and releases is busted.

https://github.com/mozilla/balrog/commit/f916721837fa9b173fc29675df69f6279b434a40
Merge pull request #34 from bhearsum/fix-revert-button

bug 1164289: reverting to prior rules and releases is busted. r=nthomas

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] (away Dec 21-Jan 24) from comment #2)
> Saw this today too. Any idea which bug you mean instead of bug 1163170 ?

Just saw this comment...no idea which bug I meant =\.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8698972 [details] [review]
look  for json data instead of basic form data

Oops, r+'d on github but not here.

Comment 8

[[e-mail] (:bhearsum)]

This is now in production and working.