On a profile that had customized toolbars before being opened with 38.0.5 (beta), the pocket button disappears after a restart

VERIFIED FIXED in Firefox 38.0.5

Status

()

P1
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gavin, Assigned: Gijs)

Tracking

Trunk
Firefox 41
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify +

Firefox Tracking Flags

(firefox38.0.5 verified, firefox39 verified, firefox40 verified, firefox41 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I have a specific "beta" profile that I use with Firefox Beta builds, and update whenever I remember/want to test something in beta. Today I updated it from a 38.0 beta build (not sure which one) to 38.0.5beta1. After the update, the Pocket toolbar button was not in my toolbar by default (it does appear in the customize palette). I wasn't able to see whether there were any relevant Browser Console exceptions immediately after update because the console got flooded.

This profile was created long ago and probably has accumulated some cruft (though I don't use it that much, so it should be relatively clean).

I tried reproducing this by creating a profile in 38.0b5 and then running that profile in 38.0.5b1, but that didn't reproduce this bug (the pocket toolbar button showed up properly).

Not much to go on, I know - I can get stuff out of the profile that might be interesting. Dolske theorized that maybe "the version stuff in https://hg.mozilla.org/mozilla-central/rev/b2e843b2300d could have missed something".
Flags: needinfo?(gijskruitbosch+bugs)

Comment 1

4 years ago
Gavin: By any chance did you have any Pocket add-ons installed in that profile before upgrading? One of the guys on our team had a slightly different issue (the button didn't get placed next to bookmarks, but rather at the end of the toolbar). That profile had an add-on we were using for testing and the thought was that it likely conflicted with the built-in stuff. Had him try to reproduce on a clean profile and couldn't.
(Assignee)

Comment 2

4 years ago
What does the customizableUI state pref in that profile look like?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(gavin.sharp)
(Assignee)

Comment 3

4 years ago
Also, what is the value of browser.toolbarbuttons.introduced.pocket-button, and if you set it back to false (it should be true!) and restart the browser, does it get introduced then? (please try this after checking the value of the customizableui state, which is in the browser.uiCustomization.state pref).
(In reply to Nate Weiner from comment #1)
> Gavin: By any chance did you have any Pocket add-ons installed in that
> profile before upgrading?

I'm pretty sure I hadn't installed the Pocket add-on in this profile before.

(In reply to :Gijs Kruitbosch from comment #2)
> What does the customizableUI state pref in that profile look like?

{"placements":{"PanelUI-contents":["edit-controls","zoom-controls","new-window-button","privatebrowsing-button","save-page-button","print-button","history-panelmenu","fullscreen-button","find-button","preferences-button","add-ons-button","developer-button"],"addon-bar":["addonbar-closebutton","customizableui-special-spring1","status-bar"],"PersonalToolbar":["personal-bookmarks"],"nav-bar":["unified-back-forward-button","urlbar-container","reload-button","stop-button","search-container","webrtc-status-button","bookmarks-menu-button","downloads-button","home-button","window-controls","social-share-button","pilot-notification-popup","loop-button-throttled","loop-button"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button","tabs-closebutton"]},"seen":[],"dirtyAreaCache":["addon-bar","PersonalToolbar","nav-bar","TabsToolbar","PanelUI-contents"],"currentVersion":4,"newElementCount":1}
Flags: needinfo?(gavin.sharp)
browser.toolbarbuttons.introduced.pocket-button was true. Flipping it to false and restarting added the Pocket button.

browser.uiCustomization.state is now:

{"placements":{"PanelUI-contents":["edit-controls","zoom-controls","new-window-button","privatebrowsing-button","save-page-button","print-button","history-panelmenu","fullscreen-button","find-button","preferences-button","add-ons-button","developer-button"],"addon-bar":["addonbar-closebutton","customizableui-special-spring1","status-bar"],"PersonalToolbar":["personal-bookmarks"],"nav-bar":["unified-back-forward-button","urlbar-container","reload-button","stop-button","search-container","webrtc-status-button","bookmarks-menu-button","downloads-button","home-button","window-controls","social-share-button","pilot-notification-popup","loop-button-throttled","loop-button"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button","tabs-closebutton"]},"seen":[],"dirtyAreaCache":["addon-bar","PersonalToolbar","nav-bar","TabsToolbar","PanelUI-contents"],"currentVersion":4,"newElementCount":1}
(Assignee)

Comment 6

4 years ago
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #5)
> browser.toolbarbuttons.introduced.pocket-button was true. Flipping it to
> false and restarting added the Pocket button.
> 
> browser.uiCustomization.state is now:
> 
> {"placements":{"PanelUI-contents":["edit-controls","zoom-controls","new-
> window-button","privatebrowsing-button","save-page-button","print-button",
> "history-panelmenu","fullscreen-button","find-button","preferences-button",
> "add-ons-button","developer-button"],"addon-bar":["addonbar-closebutton",
> "customizableui-special-spring1","status-bar"],"PersonalToolbar":["personal-
> bookmarks"],"nav-bar":["unified-back-forward-button","urlbar-container",
> "reload-button","stop-button","search-container","webrtc-status-button",
> "bookmarks-menu-button","downloads-button","home-button","window-controls",
> "social-share-button","pilot-notification-popup","loop-button-throttled",
> "loop-button"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-
> button","tabs-closebutton"]},"seen":[],"dirtyAreaCache":["addon-bar",
> "PersonalToolbar","nav-bar","TabsToolbar","PanelUI-contents"],
> "currentVersion":4,"newElementCount":1}

This doesn't have the pocket-button in it... if you restart, is the button still there? Does the pref change?
Flags: needinfo?(gavin.sharp)
(In reply to :Gijs Kruitbosch from comment #6)
> This doesn't have the pocket-button in it... if you restart, is the button
> still there? Does the pref change?

Hmm, indeed. Restarting again, the button disappears and the pref stays the same. I suppose this might be the same thing that happened initially - I may have restarted twice and not noticed that it was there after the first update.
Flags: needinfo?(gavin.sharp)
(Assignee)

Comment 8

4 years ago
I can reproduce this starting from a clean profile on 37:

1) create profile in 37
2) remove a button from the toolbar using the context menu
3) restart, check the button is still gone
4) open beta with the same profile - the pocket button will be there
5) close beta, reopen with the same profile - the pocket button will be gone again
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1155521
Status: NEW → ASSIGNED
Iteration: --- → 41.1 - May 25
Points: --- → 2
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
(Assignee)

Comment 9

4 years ago
/r/8729 - Bug 1164302 - pocket button gets lost after a restart, r?jaws

Pull down this commit:

hg pull -r d94326121daabc77b4f9f6e2f1eda601d585848f https://reviewboard-hg.mozilla.org/gecko/
Attachment #8605509 - Flags: review?(jaws)
(Assignee)

Updated

4 years ago
Summary: upgrading a beta build with an old (but recently used) profile did not put the Pocket button in my toolbar → On a profile that had customized toolbars before being opened with 38.0.5 (beta), the pocket button disappears after a restart
(Assignee)

Comment 12

4 years ago
Comment on attachment 8605509 [details]
MozReview Request: bz://1164302/Gijs

Approval Request Comment
[Feature/regressing bug #]: pocket integration
[User impact if declined]: it won't work for a large portion of our users
[Describe test coverage new/current, TreeHerder]: the existing test for this part of the implementation didn't catch this, so... no? :-(
[Risks and why]: low; however, I expect a minor performance impact. We are already tracking performance in 1163512. I believe we can address the performance issues, but for proper testing this really needs to land everywhere as soon as possible.
[String/UUID change made/needed]: no.
Attachment #8605509 - Flags: approval-mozilla-release?
Attachment #8605509 - Flags: approval-mozilla-beta?
Attachment #8605509 - Flags: approval-mozilla-aurora?
Comment on attachment 8605509 [details]
MozReview Request: bz://1164302/Gijs

a+ for all channels, required for Pocket launch in 38.0.5.
Attachment #8605509 - Flags: approval-mozilla-release?
Attachment #8605509 - Flags: approval-mozilla-release+
Attachment #8605509 - Flags: approval-mozilla-beta?
Attachment #8605509 - Flags: approval-mozilla-beta+
Attachment #8605509 - Flags: approval-mozilla-aurora?
Attachment #8605509 - Flags: approval-mozilla-aurora+
(aurora currently closed)
https://hg.mozilla.org/releases/mozilla-beta/rev/2b36336d8212
https://hg.mozilla.org/releases/mozilla-release/rev/d5ba1bc97911
status-firefox38.0.5: --- → fixed
status-firefox39: --- → fixed
status-firefox40: --- → affected
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/e36855754025
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
QA Contact: andrei.vaida
(Assignee)

Updated

4 years ago
Depends on: 1167096
Reproduced with the steps from comment 8.
Verified as fixed using Firefox 38.0.5 beta 3 under Ubuntu 14.04 LTS x86, Win 7 x64 and Mac OS X 10.9.5.
status-firefox38.0.5: fixed → verified
I was able to reproduce this issue with a Firefox 37 profile opened in Firefox 38.0.5 Beta 1.

Verified fixed on Firefox 39 Beta 1 (20150523155636), Firefox 40.0a2 (2015-05-26) and Firefox 41.0a1 (2015-05-26) using Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and Windows 7 64-bit.
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
status-firefox40: fixed → verified
status-firefox41: fixed → verified
(Assignee)

Comment 19

4 years ago
Comment on attachment 8605509 [details]
MozReview Request: bz://1164302/Gijs
Attachment #8605509 - Attachment is obsolete: true
Attachment #8620276 - Flags: review+
You need to log in before you can comment on or make changes to this bug.