Closed Bug 1164330 Opened 7 years ago Closed 7 years ago

Replace references to time fraction with (iteration) progress

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: birtles, Assigned: birtles)

Details

Attachments

(1 file, 1 obsolete file)

The spec has renamed the term to "iteration progress" and the API member to just "progress".[1] We don't expose this via the API yet but we should rename internal references to avoid confusion when comparing with the spec.

[1] https://github.com/w3c/web-animations/commit/b0738da7359533285dbd9b63a459fd140811a65d
/r/8683 - Bug 1164330 - Rename time fraction to (iteration) progress

Pull down this commit:

hg pull -r 5baa792d6218daab4ff71a15d5113e3acc099a0d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8605054 - Flags: review?(jwatt)
If an animation is playing backwards and the iteration progress is 0.7, does that mean there's 30% of the iteration still to go, or 70%?
Flags: needinfo?(bbirtles)
(In reply to Jonathan Watt [:jwatt] from comment #2)
> If an animation is playing backwards and the iteration progress is 0.7, does
> that mean there's 30% of the iteration still to go, or 70%?

70%.

In that case progress will go from 1.0 to 0.0.
Flags: needinfo?(bbirtles)
That seems weird to me, but I haven't been able to come up with a better suggestion for naming that would be less misleading. Can you at least extend the comment for the mProgress member to note that it is progress towards the end of the animation, rather than progress in the time direction?
Attachment #8605054 - Flags: review?(jwatt) → review+
https://hg.mozilla.org/mozilla-central/rev/e6826d9be450
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8605054 - Attachment is obsolete: true
Attachment #8620277 - Flags: review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.