1164330 - Replace references to time fraction with (iteration) progress

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Birtles (:birtles)]

The spec has renamed the term to "iteration progress" and the API member to just "progress".[1] We don't expose this via the API yet but we should rename internal references to avoid confusion when comparing with the spec.

[1] https://github.com/w3c/web-animations/commit/b0738da7359533285dbd9b63a459fd140811a65d

Comment 1

[Brian Birtles (:birtles)]

Attachment: MozReview Request: bz://1164330/birtles

/r/8683 - Bug 1164330 - Rename time fraction to (iteration) progress

Pull down this commit:

hg pull -r 5baa792d6218daab4ff71a15d5113e3acc099a0d https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Jonathan Watt [:jwatt]]

If an animation is playing backwards and the iteration progress is 0.7, does that mean there's 30% of the iteration still to go, or 70%?

Comment 3

[Brian Birtles (:birtles)]

(In reply to Jonathan Watt [:jwatt] from comment #2)
> If an animation is playing backwards and the iteration progress is 0.7, does
> that mean there's 30% of the iteration still to go, or 70%?

70%.

In that case progress will go from 1.0 to 0.0.

Comment 4

[Jonathan Watt [:jwatt]]

That seems weird to me, but I haven't been able to come up with a better suggestion for naming that would be less misleading. Can you at least extend the comment for the mProgress member to note that it is progress towards the end of the animation, rather than progress in the time direction?

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8605054 [details]
MozReview Request: bz://1164330/birtles

https://reviewboard.mozilla.org/r/8681/#review7419

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6826d9be450

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e6826d9be450

Comment 9

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1164330 - Rename time fraction to (iteration) progress