If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

|./build.sh gecko| should tell emulator builder to update the images too

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I wasted a day before realizing |./build.sh gecko| does not affect the actual Emulator image in which I need to run some mochitests on. 

There are 3 options to reduce this confusion:

1. Also re-generate the images for all ./build.sh calls for emulator config
2. Also re-generate the images for all ./build.sh calls for all configs
3. Add a check in ./build.sh to stop a module build instruction for emulators since there is no meaningful use case (you can |./flash.sh gecko| to the live emulator but it goes away when powered off)

:mwu, do you agree with any of the options above? How can we achieve either (1) or (2) if you agree we should do it?
Flags: needinfo?(mwu)

Comment 1

2 years ago
(for some reason I thought I responded to this already..)

Yeah, I agree this is very unexpected.

How about suggesting the user run "./build.sh snod" (systemimage-nodeps) after "./build.sh gecko"? The message can always be displayed since it's useful in general, but it can also mention that it's required for emulators (maybe make it red/bold when run on an emulator).

#3 also sounds good to me, but I'm not 100% certain that it's the right thing for all users. The emulator does take some time to startup so it's possible to save time by using ./flash.sh gecko while leaving the emulator up.
Flags: needinfo?(mwu)
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Summary: |./build.sh gecko| or other module build runs should update the image for emulator builds → |./build.sh gecko| should tell emulator builder to update the images too
Created attachment 8609971 [details] [review]
https://github.com/mozilla-b2g/B2G/pull/445

A warning w/o change in behavior is the safest way to achieve the goal.
Attachment #8609971 - Flags: review?(mwu)

Comment 3

2 years ago
Comment on attachment 8609971 [details] [review]
https://github.com/mozilla-b2g/B2G/pull/445

Didn't know about tput - very nice.

Just one nit - snod doesn't update all images. It only updates the system image, which is the only image that needs to be updated to update gecko. r=me with that adjusted.
Attachment #8609971 - Flags: review?(mwu) → review+
Fixed and merged: https://github.com/mozilla-b2g/B2G/commit/5e0afe3f2330cb94eca26af85122c035fcd63d1f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.