I wasted a day before realizing |./build.sh gecko| does not affect the actual Emulator image in which I need to run some mochitests on. There are 3 options to reduce this confusion: 1. Also re-generate the images for all ./build.sh calls for emulator config 2. Also re-generate the images for all ./build.sh calls for all configs 3. Add a check in ./build.sh to stop a module build instruction for emulators since there is no meaningful use case (you can |./flash.sh gecko| to the live emulator but it goes away when powered off) :mwu, do you agree with any of the options above? How can we achieve either (1) or (2) if you agree we should do it?
(for some reason I thought I responded to this already..) Yeah, I agree this is very unexpected. How about suggesting the user run "./build.sh snod" (systemimage-nodeps) after "./build.sh gecko"? The message can always be displayed since it's useful in general, but it can also mention that it's required for emulators (maybe make it red/bold when run on an emulator). #3 also sounds good to me, but I'm not 100% certain that it's the right thing for all users. The emulator does take some time to startup so it's possible to save time by using ./flash.sh gecko while leaving the emulator up.
Created attachment 8609971 [details] [review] https://github.com/mozilla-b2g/B2G/pull/445 A warning w/o change in behavior is the safest way to achieve the goal.
Comment on attachment 8609971 [details] [review] https://github.com/mozilla-b2g/B2G/pull/445 Didn't know about tput - very nice. Just one nit - snod doesn't update all images. It only updates the system image, which is the only image that needs to be updated to update gecko. r=me with that adjusted.
Fixed and merged: https://github.com/mozilla-b2g/B2G/commit/5e0afe3f2330cb94eca26af85122c035fcd63d1f