[OSX] Pocket panel for ru locale build has misaligned elements

VERIFIED FIXED in Firefox 38.0.5

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: petruta.rasa, Assigned: nate)

Tracking

38 Branch
Firefox 41
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38.0.5 verified, firefox39 fixed, firefox40 fixed, firefox41 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Posted image Pocket panel
Reproducible with Firefox 38.0.5 beta 1 build 2, ru locale.

Str: 1. Login to Pocket and load a page in a new tab
2. Select the Pocket toolbar icon to add the page to Pocket list

ER: A message is displayed to inform the user that the page was added. Tags can be added to that page. Everything looks correctly, no scrollbar

AR: The elements are not properly aligned. Scrollbar is visible.
Please see the attachment.
[Tracking Requested - why for this release]:

This looks bad, we should fix this or disable Russian.
Hmm, the May 9th code drop () improved localized layout, but it wasn't this broken before or after in screenshots of Pocket's testing of that drop. https://www.dropbox.com/s/tw9ju4x1cxg0yxm/Screenshot%202015-05-13%2011.43.07.png?dl=0
Posted patch pocketPanelWidth.patch (obsolete) — Splinter Review
The issue was an unexpected css selector on the panel setting the max-width of the panel to 30em. This made the saved panel 8px smaller than it should have been which broke the layout for the much longer ru strings.

The offending selector was:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#244

Dolske suggested the new selector that is in this patch (we worked through it live on IRC together, I'm just submitting the patch file).
Attachment #8605527 - Flags: review?(jaws)
Attachment #8605527 - Flags: review?(dolske)
Posted patch Patch v.2Splinter Review
I made the last part of the selector a little stricter (matching the original one above it), just to be extra safe. (I also verified that it's still wider and makes the RU panel contents fit correctly.)
Attachment #8605527 - Attachment is obsolete: true
Attachment #8605527 - Flags: review?(jaws)
Attachment #8605527 - Flags: review?(dolske)
Attachment #8605595 - Flags: review+
Comment on attachment 8605595 [details] [diff] [review]
Patch v.2

[Triage Comment]

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8605595 - Flags: approval-mozilla-release+
Attachment #8605595 - Flags: approval-mozilla-beta+
Attachment #8605595 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/e5e46e9b5c79
Assignee: nobody → nate
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: qe-verify+
Depends on: 1163360
Verified as fixed using Firefox 38.0.5 beta 3 under Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Component: Pocket → Location Bar
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.