1164419 - [OSX] Pocket panel for ru locale build has misaligned elements

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea]]

Attachment: Pocket panel

Reproducible with Firefox 38.0.5 beta 1 build 2, ru locale.

Str: 1. Login to Pocket and load a page in a new tab
2. Select the Pocket toolbar icon to add the page to Pocket list

ER: A message is displayed to inform the user that the page was added. Tags can be added to that page. Everything looks correctly, no scrollbar

AR: The elements are not properly aligned. Scrollbar is visible.
Please see the attachment.

Comment 1

[Axel Hecht [:Pike]]

[Tracking Requested - why for this release]:

This looks bad, we should fix this or disable Russian.

Comment 2

[Justin Dolske [:Dolske]]

Hmm, the May 9th code drop () improved localized layout, but it wasn't this broken before or after in screenshots of Pocket's testing of that drop. https://www.dropbox.com/s/tw9ju4x1cxg0yxm/Screenshot%202015-05-13%2011.43.07.png?dl=0

Comment 3

[Justin Dolske [:Dolske]]

I can reproduce with a build from https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/38.0.5b1-candidates/build2/mac/ru/

Comment 4

[Nate Weiner]

Attachment: pocketPanelWidth.patch

The issue was an unexpected css selector on the panel setting the max-width of the panel to 30em. This made the saved panel 8px smaller than it should have been which broke the layout for the much longer ru strings.

The offending selector was:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#244

Dolske suggested the new selector that is in this patch (we worked through it live on IRC together, I'm just submitting the patch file).

Comment 5

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

I made the last part of the selector a little stricter (matching the original one above it), just to be extra safe. (I also verified that it's still wider and makes the RU panel contents fit correctly.)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e5e46e9b5c79

Comment 7

[Justin Dolske [:Dolske]]

Comment on attachment 8605595 [details] [diff] [review]
Patch v.2

[Triage Comment]

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.

Comment 8

[Justin Dolske [:Dolske]]

(aurora currently closed)
https://hg.mozilla.org/releases/mozilla-beta/rev/0c7b1e15da63
https://hg.mozilla.org/releases/mozilla-release/rev/f724af08988f

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5e46e9b5c79

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c8d0128cfe86

Comment 11

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 38.0.5 beta 3 under Mac OS X 10.9.5.