1164476 - [e10s] Disable "disable flash protected mode" functionality under e10s

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

Since we don't know if this helps or hurts with e10s we should turn this off so it doesn't trigger when e10s is running. Unfortunately once this pref is set it looks like it stays that way so we'll still get this under e10s if someone was prompted under non-e10s. But that's out of our control. At least we can stop from triggering it for now.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Benjamin Smedberg]

I don't understand.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

This patch looks okay, but like bsmedberg I am a bit unsure as to the necessity of this. Have there been problems?

Comment 4

[Jim Mathies [:jimm]]

(In reply to Aaron Klotz [:aklotz] (please use needinfo) from comment #3)
> This patch looks okay, but like bsmedberg I am a bit unsure as to the
> necessity of this. Have there been problems?

I'm unsure of the necessity of turning flash protected mode off. :) I'd like to assume that whatever bug we tried to fix with this isn't present with e10s enabled, or if it is present, we can look at fixing it in a better way. In the mean time my goal here is to simply disable this so that it doesn't cause problems or confusing when we debug flash deadlock issues.

Comment 5

[Jim Mathies [:jimm]]

s/confusing/confusion

Comment 6

[Benjamin Smedberg]

We know that the majority of the Flash deadlock issues are caused by protected mode, and I wouldn't expect that to be much better with e10s. I think having this checkbox continue to work and being able to test whether a particular deadlock scenario only happens with protected mode enabled would be quite valuable.

Comment 7

[Jim Mathies [:jimm]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> We know that the majority of the Flash deadlock issues are caused by
> protected mode, and I wouldn't expect that to be much better with e10s.

e10s deadlock rates are about 1/3 that of non-e10s so there are differences in behavior here. I think establishing a baseline with protected mode (and testing with it off using about:config occasionally) is a good approach. e10s + least-supported flash mode seems like a bad place to start from.

> I think having this checkbox continue to work and being able to test whether a
> particular deadlock scenario only happens with protected mode enabled would
> be quite valuable.

My patch disables auto-disable of protected mode but not the pref, so we can continue to test using this.

Comment 8

[Jim Mathies [:jimm]]

Do we have any idea how many users have this set?

Comment 9

[Benjamin Smedberg]

I don't understand what "My patch disables auto-disable of protected mode but not the pref" means. The patch disables the functionality of the pref when e10s is enabled.

Hopefully only a few people will have the pref set: people who have come to SUMO because of persistent Flash hangs and were directed to use the checkbox to make the problem better.

Comment 10

[Justin [:JW_SoftvisionQA]]

Is this issue still in the works or could this be closed?