Closed Bug 1164525 Opened 5 years ago Closed 5 years ago

[B2G] Ignore GAIADIR for B2G device builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

The environment variable GAIADIR is used for B2G desktop to package a gaia profile with the build. If it is set for a B2G device build, it will produce an unbootable image/gecko. It should be ignored in the configure script for those targets.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Attachment #8605340 - Flags: review?(fabrice)
Comment on attachment 8605340 [details] [diff] [review]
bug1164525.patch, v1

Review of attachment 8605340 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'm not a build peer.
Attachment #8605340 - Flags: review?(mshal)
Attachment #8605340 - Flags: review?(fabrice)
Attachment #8605340 - Flags: feedback+
Comment on attachment 8605340 [details] [diff] [review]
bug1164525.patch, v1

Looks good to me - though we don't normally set GAIADIR in the environment, but rather in the mozconfig. Just curious, how did you end up with GAIADIR being set on device builds?
Attachment #8605340 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #3)
> Comment on attachment 8605340 [details] [diff] [review]
> bug1164525.patch, v1
> 
> Looks good to me - though we don't normally set GAIADIR in the environment,
> but rather in the mozconfig. Just curious, how did you end up with GAIADIR
> being set on device builds?

Thanks! russn reported a problem where his device builds wouldn't boot and we eventually isolated it to this variable being set in his environment. I'm not sure why he had it set, but I'm guessing it was forgotten in the .profile file or something as it had been a while since he had done a gecko build. Given how much grief it caused, I figured it was best to fix the configure script :).
https://hg.mozilla.org/mozilla-central/rev/58269a48a737
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.