1164525 - [B2G] Ignore GAIADIR for B2G device builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

The environment variable GAIADIR is used for B2G desktop to package a gaia profile with the build. If it is set for a B2G device build, it will produce an unbootable image/gecko. It should be ignored in the configure script for those targets.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1164525.patch, v1

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8605340 [details] [diff] [review]
bug1164525.patch, v1

Review of attachment 8605340 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'm not a build peer.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8605340 [details] [diff] [review]
bug1164525.patch, v1

Looks good to me - though we don't normally set GAIADIR in the environment, but rather in the mozconfig. Just curious, how did you end up with GAIADIR being set on device builds?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Michael Shal [:mshal] from comment #3)
> Comment on attachment 8605340 [details] [diff] [review]
> bug1164525.patch, v1
> 
> Looks good to me - though we don't normally set GAIADIR in the environment,
> but rather in the mozconfig. Just curious, how did you end up with GAIADIR
> being set on device builds?

Thanks! russn reported a problem where his device builds wouldn't boot and we eventually isolated it to this variable being set in his environment. I'm not sure why he had it set, but I'm guessing it was forgotten in the .profile file or something as it had been a while since he had done a gecko build. Given how much grief it caused, I figured it was best to fix the configure script :).

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71e330cf2bfb

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/58269a48a737

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58269a48a737