[Customizer] Customizer 'open' gesture is difficult on devices with SHB

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::System::System UI
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

unspecified
2.2 S13 (29may)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.5+, b2g-master fixed)

Details

(Whiteboard: [spark][systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The gesture for opening the Customizer is 2-fingers swipe upwards from near the bottom of the screen. On the Z3C, there is a software home button and if you start the gesture too low on the screen near the SHB, the gesture does not get detected. It seems as though the SHB is blocking touch events from reaching the app.
(Assignee)

Comment 1

3 years ago
[Blocking Requested - why for this release]: This impairs the discoverability of the Customizer add-on and is a bad user experience in general.

Flagging alive for NI?
Blocks: 1133943
blocking-b2g: --- → spark?
Component: Gaia::Customizer → Gaia::System::Window Mgmt
Flags: needinfo?(alive)
Priority: -- → P1
Whiteboard: [spark]
blocking-b2g: spark? → spark+
Software Home issue, transfer NI to Michael.
Component: Gaia::System::Window Mgmt → Gaia::System::System UI
Flags: needinfo?(alive) → needinfo?(mhenretty)
Whiteboard: [spark] → [spark][systemsfe]
Justin and I spoke on IRC about this problem. It sounds like the best approach is to have some code in the Customizer add-on that only runs in the system app and which triggers the Customizer code in the curent app when the 2 finger swipe gesture is detected on the system window.
Flags: needinfo?(mhenretty)
(Assignee)

Comment 4

3 years ago
I'm taking this based on feedback given by mhenretty to inject the gesture detection into the System app (similar to edge gestures):

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/edge_swipe_detector.js#L207
Assignee: nobody → jdarcangelo
(Assignee)

Comment 5

3 years ago
Created attachment 8607754 [details] [review]
pull-request (master)
Attachment #8607754 - Flags: review?(drs)
Comment on attachment 8607754 [details] [review]
pull-request (master)

Looks good, see my comments on the PR.
Attachment #8607754 - Flags: review?(drs) → review+
(Assignee)

Comment 7

3 years ago
Landed on master:

https://github.com/fxos/customizer/commit/0a8782826e665f0baccfd60a2c633516fe2577f3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
blocking-b2g: spark+ → 2.5+
status-b2g-v2.5: --- → fixed
status-b2g-master: --- → fixed
Target Milestone: --- → 2.2 S13 (29may)
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.