Closed Bug 1164536 Opened 5 years ago Closed 5 years ago

[Customizer] Customizer 'open' gesture is difficult on devices with SHB

Categories

(Firefox OS Graveyard :: Gaia::System::System UI, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-master fixed)

RESOLVED FIXED
2.2 S13 (29may)
blocking-b2g 2.5+
Tracking Status
b2g-master --- fixed

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark][systemsfe])

Attachments

(1 file)

The gesture for opening the Customizer is 2-fingers swipe upwards from near the bottom of the screen. On the Z3C, there is a software home button and if you start the gesture too low on the screen near the SHB, the gesture does not get detected. It seems as though the SHB is blocking touch events from reaching the app.
[Blocking Requested - why for this release]: This impairs the discoverability of the Customizer add-on and is a bad user experience in general.

Flagging alive for NI?
blocking-b2g: --- → spark?
Component: Gaia::Customizer → Gaia::System::Window Mgmt
Flags: needinfo?(alive)
Priority: -- → P1
Whiteboard: [spark]
blocking-b2g: spark? → spark+
Software Home issue, transfer NI to Michael.
Component: Gaia::System::Window Mgmt → Gaia::System::System UI
Flags: needinfo?(alive) → needinfo?(mhenretty)
Whiteboard: [spark] → [spark][systemsfe]
Justin and I spoke on IRC about this problem. It sounds like the best approach is to have some code in the Customizer add-on that only runs in the system app and which triggers the Customizer code in the curent app when the 2 finger swipe gesture is detected on the system window.
Flags: needinfo?(mhenretty)
I'm taking this based on feedback given by mhenretty to inject the gesture detection into the System app (similar to edge gestures):

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/edge_swipe_detector.js#L207
Assignee: nobody → jdarcangelo
Attached file pull-request (master)
Attachment #8607754 - Flags: review?(drs)
Comment on attachment 8607754 [details] [review]
pull-request (master)

Looks good, see my comments on the PR.
Attachment #8607754 - Flags: review?(drs) → review+
Landed on master:

https://github.com/fxos/customizer/commit/0a8782826e665f0baccfd60a2c633516fe2577f3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
blocking-b2g: spark+ → 2.5+
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.