Closed Bug 1164559 Opened 10 years ago Closed 10 years ago

Remove usage of |#ifdef PR_LOGGING| from storage

Categories

(Core :: SQLite and Embedded Database Bindings, defect)

Product:
Core
Component:
SQLite and Embedded Database Bindings
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files)

Part 1: Remove instances of #ifdef PR_LOGGING in storage
8.00 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 2: Wrap expensive calls in PR_LOG_TEST
3.29 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8605429 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8605430 - Flags: review?(nfroyd)
Attachment #8605429 - Flags: review?(nfroyd) → review+
Attachment #8605430 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/1e0f32a8185e https://hg.mozilla.org/mozilla-central/rev/3a3ab74e0e62
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Product: Toolkit → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: