Closed Bug 1164569 Opened 9 years ago Closed 8 years ago

text overlaps image on SSLv3 error page with small firefox windows

Categories

(Firefox :: Security, defect)

All
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox41 --- affected
firefox46 --- fixed

People

(Reporter: pollti, Assigned: pollti)

References

()

Details

Attachments

(2 files, 1 obsolete file)

When I visit a website using SSLv3, I get the error page updated in Bug 1089808. When I use a small Firefox window here, the text overlaps the image.

STR:
# Visit any website using SSLv3 (e.g. https://mtsindia.in/).
# Reduce your Firefox window's size until the text overlaps the image.

Actual result:
The text overlaps the image.

Expected result:
There should be another possibility to show the error page for small windows.
OS: Windows 8.1 → Windows 10
Hardware: x86_64 → All
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20151223030323

I can't reproduce this issue anymore using the latest Nightly version (at least not by following the scenario from the Description).

Tim, are you still able to reproduce this issue?
Flags: needinfo?(pollti)
The website mentioned in the description seems to be fixed in the meantime, so I can't reproduce it at the moment. Do you know any website causing the sslv3 error message, so we can check how the error message looks like at the moment?
Flags: needinfo?(pollti)
The icon is removed for smaller windows now, so the problem seems to be fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Sorry, it only works for other error messages like https://wrong.host.badssl.com/. It is not fixed for https://rc4.badssl.com/ yet (but it should hopefully be a quick fix since the code propably exists for other error messages).
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Attached patch patch, v1 (obsolete) — Splinter Review
This should hopefully fix the issue.
Assignee: nobody → pollti
Status: REOPENED → ASSIGNED
Attachment #8702296 - Flags: review?(mak77)
Comment on attachment 8702296 [details] [diff] [review]
patch, v1

Review of attachment 8702296 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know much about design decisions of security pages, maybe someone working on privacy and security has more insight.
Attachment #8702296 - Flags: review?(mak77) → review?(past)
Comment on attachment 8702296 [details] [diff] [review]
patch, v1

Review of attachment 8702296 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/aboutNetError.css
@@ +71,5 @@
>      -moz-margin-start: 0;
>    }
> +  #errorTitle[sslv3=true],
> +  #errorTitle[weakCrypto=true] {
> +    background-image: none;

Why not reset everything else as well in these cases? That is, change it to something like:

#errorTitle,
#errorTitle[sslv3=true],
#errorTitle[weakCrypto=true] {
...
}
Attachment #8702296 - Flags: review?(past)
Attached patch patch, v2Splinter Review
Thanks, you're right.
Although this propably doesn't change the behavior, it is easier to read.
Attachment #8702296 - Attachment is obsolete: true
Attachment #8703280 - Flags: review?(past)
Comment on attachment 8703280 [details] [diff] [review]
patch, v2

Review of attachment 8703280 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8703280 - Flags: review?(past) → review+
Component: Untriaged → Security
Thanks for reviewing the patch.
Keywords: checkin-needed
Thanks! :)
https://hg.mozilla.org/mozilla-central/rev/a5d53deacf63
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
QA Whiteboard: [good first verify]
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test successful and bug fixed.

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
1. Seems to be fixed.Icon disappears and no text overlapping when FF window minimized.
2. There is an error page for small windows.

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.