Closed
Bug 1164569
Opened 9 years ago
Closed 8 years ago
text overlaps image on SSLv3 error page with small firefox windows
Categories
(Firefox :: Security, defect)
Tracking
()
RESOLVED
FIXED
Firefox 46
People
(Reporter: pollti, Assigned: pollti)
References
()
Details
Attachments
(2 files, 1 obsolete file)
35.64 KB,
image/png
|
Details | |
548 bytes,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
When I visit a website using SSLv3, I get the error page updated in Bug 1089808. When I use a small Firefox window here, the text overlaps the image. STR: # Visit any website using SSLv3 (e.g. https://mtsindia.in/). # Reduce your Firefox window's size until the text overlaps the image. Actual result: The text overlaps the image. Expected result: There should be another possibility to show the error page for small windows.
Assignee | ||
Updated•9 years ago
|
OS: Windows 8.1 → Windows 10
Hardware: x86_64 → All
Comment 1•8 years ago
|
||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0 Build ID: 20151223030323 I can't reproduce this issue anymore using the latest Nightly version (at least not by following the scenario from the Description). Tim, are you still able to reproduce this issue?
Flags: needinfo?(pollti)
Assignee | ||
Comment 2•8 years ago
|
||
The website mentioned in the description seems to be fixed in the meantime, so I can't reproduce it at the moment. Do you know any website causing the sslv3 error message, so we can check how the error message looks like at the moment?
Flags: needinfo?(pollti)
Assignee | ||
Comment 3•8 years ago
|
||
The icon is removed for smaller windows now, so the problem seems to be fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 4•8 years ago
|
||
Sorry, it only works for other error messages like https://wrong.host.badssl.com/. It is not fixed for https://rc4.badssl.com/ yet (but it should hopefully be a quick fix since the code propably exists for other error messages).
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Comment 5•8 years ago
|
||
This should hopefully fix the issue.
Comment 6•8 years ago
|
||
Comment on attachment 8702296 [details] [diff] [review] patch, v1 Review of attachment 8702296 [details] [diff] [review]: ----------------------------------------------------------------- I don't know much about design decisions of security pages, maybe someone working on privacy and security has more insight.
Attachment #8702296 -
Flags: review?(mak77) → review?(past)
Comment 7•8 years ago
|
||
Comment on attachment 8702296 [details] [diff] [review] patch, v1 Review of attachment 8702296 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/shared/aboutNetError.css @@ +71,5 @@ > -moz-margin-start: 0; > } > + #errorTitle[sslv3=true], > + #errorTitle[weakCrypto=true] { > + background-image: none; Why not reset everything else as well in these cases? That is, change it to something like: #errorTitle, #errorTitle[sslv3=true], #errorTitle[weakCrypto=true] { ... }
Attachment #8702296 -
Flags: review?(past)
Assignee | ||
Comment 8•8 years ago
|
||
Thanks, you're right. Although this propably doesn't change the behavior, it is easier to read.
Attachment #8702296 -
Attachment is obsolete: true
Attachment #8703280 -
Flags: review?(past)
Comment 9•8 years ago
|
||
Comment on attachment 8703280 [details] [diff] [review] patch, v2 Review of attachment 8703280 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8703280 -
Flags: review?(past) → review+
Updated•8 years ago
|
Component: Untriaged → Security
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 12•8 years ago
|
||
Thanks! :)
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a5d53deacf63
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•8 years ago
|
QA Whiteboard: [good first verify]
Comment 14•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> VERIFIED Comments: Test successful and bug fixed. Component: Name Firefox Version 46.0b4 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: 1. Seems to be fixed.Icon disappears and no text overlapping when FF window minimized. 2. There is an error page for small windows. Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•