1164587 - Get rid of Fault() in the cycle collector

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

These can just be calls to MOZ_CRASH(). If somebody wants more information about the crash, they are probably going to use a debugger anyways.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Get rid of Fault() in the cycle collector.

Comment 2

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e75af4955d

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8605558 [details] [diff] [review]
Get rid of Fault() in the cycle collector.

indeed. Don't recall any case when Fault would have provided anything useful.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Use MOZ_RELEASE_ASSERT in the CC.

MOZ_RELEASE_ASSERT is better. I'll land this folded into the other patch. I also shortened a few of the error messages.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45575bf42215

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/45575bf42215