Get rid of Fault() in the cycle collector

RESOLVED FIXED in Firefox 41

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
These can just be calls to MOZ_CRASH(). If somebody wants more information about the crash, they are probably going to use a debugger anyways.
(Assignee)

Comment 1

3 years ago
Created attachment 8605558 [details] [diff] [review]
Get rid of Fault() in the cycle collector.
Attachment #8605558 - Flags: review?(bugs)

Comment 3

3 years ago
Comment on attachment 8605558 [details] [diff] [review]
Get rid of Fault() in the cycle collector.

indeed. Don't recall any case when Fault would have provided anything useful.
Attachment #8605558 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8606345 [details] [diff] [review]
Use MOZ_RELEASE_ASSERT in the CC.

MOZ_RELEASE_ASSERT is better. I'll land this folded into the other patch. I also shortened a few of the error messages.
Attachment #8606345 - Flags: review?(bugs)

Updated

3 years ago
Attachment #8606345 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/45575bf42215
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.