1164610 - [FlatFish] Build failed because UDAT_PATTERN in js/src/builtin/Intl.cpp is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Juan Gomez [:_AtilA_] (CET/CEST)]

Since ICU library >= 5.0 we are using external ICU library instead of Mozilla implementation. This causes the build break.
As per IRC conversation, we are going to check for JB4.2 proper ANDROID_VERSION into icu.m4, to fallback to Mozilla implementation.

Comment 1

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: 0001-Bug-1164610-Increase-ANDROID_VERSION-to-18-in-icu.m4.patch

Comment 2

[Yousef Alam [:yalam96] (use NEEDINFO)]

Tested this patch, it gets us past this particular build break.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8606745 [details] [diff] [review]
0001-Bug-1164610-Increase-ANDROID_VERSION-to-18-in-icu.m4.patch

Review of attachment 8606745 [details] [diff] [review]:
-----------------------------------------------------------------

This is kinda rubberstampy, I don't know Android nonsense, but okay.

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc63e1884857

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/15798388e9f1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15798388e9f1