Closed Bug 1164616 Opened 5 years ago Closed 5 years ago

nsFrameLoader::DelayedStartLoadingRunnable is unused

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: billm, Assigned: PierV, Mentored)

Details

(Whiteboard: [lang=c++][good first bug])

Attachments

(1 file)

It looks like we can remove it.
Relevant code: http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFrameLoader.cpp
Mentor: josh
Whiteboard: [lang=c++][good first bug]
Attached patch bug1164616.patchSplinter Review
Deleted the class DelayedStartLoadingRunnable from nsFrameLoader.cpp
Attachment #8608600 - Flags: review?(josh)
Comment on attachment 8608600 [details] [diff] [review]
bug1164616.patch

Review of attachment 8608600 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8608600 - Flags: review?(josh) → review+
Assignee: nobody → piervi_parisi
I was going to merge this right now, but the tree is closed (https://treestatus.mozilla.org/). The usual procedure is to add the `checkin-needed` keyword in the Keywords field (which will cause someone else to come and merge this patch when the tree reopens) but we need to run it through our automated testing first: https://wiki.mozilla.org/ReleaseEngineering/TryServer . Why don't you go ahead and apply for the required access (http://www.mozilla.org/hacking/commit-access-policy/)?
Sure, I will!
It's my first submission, I hope I did it alright. In case I forgot something just let me know and I will be more precise in the next patch. :)
I'm going to take a look at the procedure you linked and maybe kindly ask you some question if there's something I don't understand.
I've submitted the access request this morning. As soon as I get the response, I'll proceed with testing. ;)
How can I individuate which tests to perform?
They're quite a lot...
Flags: needinfo?(josh)
http://trychooser.pub.build.mozilla.org/ allows reducing them. In this case turning on all platforms but no test should be fine - if the code compiles, that's all we care about.
Flags: needinfo?(josh)
And then you can put checkin-needed keyword to get this landed, if you don't have rights to commit to mozilla-inbound.
(those Android failures look bogus)
Alright then!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/61440ec93192
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.