Remove usage of |#ifdef PR_LOGGING| from media/

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

Trunk
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

4 years ago
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
Assignee

Comment 1

4 years ago
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8605469 - Flags: review?(nfroyd)
Assignee

Updated

4 years ago
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee

Comment 2

4 years ago
Avoid using a strstream if the given log level is not enabled.
Attachment #8605470 - Flags: review?(ekr)
Comment on attachment 8605470 [details] [diff] [review]
Part 2: Wrap expensive calls in PR_LOG_TEST

Review of attachment 8605470 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8605470 - Flags: review?(ekr) → review+
Attachment #8605469 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/ced96b3a9ac7
https://hg.mozilla.org/mozilla-central/rev/d65f1ee84fbb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.