Closed Bug 1164622 Opened 6 years ago Closed 6 years ago

Remove usage of |#ifdef PR_LOGGING| from media/

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files)

In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8605469 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Avoid using a strstream if the given log level is not enabled.
Attachment #8605470 - Flags: review?(ekr)
Comment on attachment 8605470 [details] [diff] [review]
Part 2: Wrap expensive calls in PR_LOG_TEST

Review of attachment 8605470 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8605470 - Flags: review?(ekr) → review+
Attachment #8605469 - Flags: review?(nfroyd) → review+
You need to log in before you can comment on or make changes to this bug.