Closed
Bug 1164622
Opened 9 years ago
Closed 9 years ago
Remove usage of |#ifdef PR_LOGGING| from media/
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
|
6.33 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
|
1.43 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
In bug 1161238 we plan on removing |--disable-logging| which makes |#ifdef PR_LOGGING| redundant.
|
Assignee | |
Comment 1•9 years ago
|
||
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
Attachment #8605469 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
Avoid using a strstream if the given log level is not enabled.
Attachment #8605470 -
Flags: review?(ekr)
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8605470 [details] [diff] [review]
Part 2: Wrap expensive calls in PR_LOG_TEST
Review of attachment 8605470 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8605470 -
Flags: review?(ekr) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8605469 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ced96b3a9ac7
https://hg.mozilla.org/mozilla-central/rev/d65f1ee84fbb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•