1164644 - [Customizer] Update Attributes/Properties inspectors to proper UX visual design

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

Description

[Justin D'Arcangelo [:justindarc]]

The Attributes and Properties panels need updated to reflect the visual design provided in Bug 1133943.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8605966 [details] [review]
pull-request (master)

Changing to feedback? since this isn't completely ready yet and its shaping up to be a rather large patch.

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8605966 [details] [review]
pull-request (master)

I like the approach. I left some pretty granular comments on the PR because I forgot that you were asking for feedback and not review.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8605966 [details] [review]
pull-request (master)

Ok, I think we're ready to review this MegaPatch (TM). We can always just do follow-ups to refine this further, but I don't want it to get too big before landing.

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8605966 [details] [review]
pull-request (master)

Amazing work, Justin. The code is very clean and well-organized, and the feature works much better than the previous implementation. I left a few comments on the PR, but we won't need another review round after fixing them.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Addressed comments in PR.

Landed on master:

https://github.com/fxos/customizer/commit/be5a0ac7cfaad10f0d4525e8e61efbb0c5254bb1