Closed Bug 1164644 Opened 5 years ago Closed 4 years ago

[Customizer] Update Attributes/Properties inspectors to proper UX visual design

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

The Attributes and Properties panels need updated to reflect the visual design provided in Bug 1133943.
Assignee: nobody → jdarcangelo
Priority: -- → P1
Whiteboard: [spark]
Attached file pull-request (master)
Attachment #8605966 - Flags: review?(drs)
Comment on attachment 8605966 [details] [review]
pull-request (master)

Changing to feedback? since this isn't completely ready yet and its shaping up to be a rather large patch.
Attachment #8605966 - Flags: review?(drs) → feedback?(drs)
Comment on attachment 8605966 [details] [review]
pull-request (master)

I like the approach. I left some pretty granular comments on the PR because I forgot that you were asking for feedback and not review.
Attachment #8605966 - Flags: feedback?(drs) → feedback+
Comment on attachment 8605966 [details] [review]
pull-request (master)

Ok, I think we're ready to review this MegaPatch (TM). We can always just do follow-ups to refine this further, but I don't want it to get too big before landing.
Attachment #8605966 - Flags: review?(drs)
Comment on attachment 8605966 [details] [review]
pull-request (master)

Amazing work, Justin. The code is very clean and well-organized, and the feature works much better than the previous implementation. I left a few comments on the PR, but we won't need another review round after fixing them.
Attachment #8605966 - Flags: review?(drs) → review+
Addressed comments in PR.

Landed on master:

https://github.com/fxos/customizer/commit/be5a0ac7cfaad10f0d4525e8e61efbb0c5254bb1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.