Closed Bug 1164649 Opened 9 years ago Closed 9 years ago

More late string changes in Pocket

Categories

(Firefox :: Pocket, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file, 2 obsolete files)

The changes in bug 1162713 and bug 1164161 are making some further string adjustments, but they're really just picking up a few strings Pocket previously had translated in their product. Still, Axel wisely suggested that we make sure localizers for the affected locales have a chance to review strings, so let's do that in in this bug.

Sorry another round of late strings. :(
Attached patch Updated strings, v.1 (obsolete) — Splinter Review
CC'd localizers from bug 1161843 / bug 1161841 / bug 1161842 / bug 1161844:

Can you review these and let us know if any changes are needed?

I intend to go ahead and land these strings as-is in the respective bugs in comment 0, but we'll be able to fix these for either beta2 (if updated by tomorrow morning Pacific time), or beta3 (if updated by Monday morning Pacific time).
diff --git a/browser/base/content/browser-pocket-ru.properties b/browser/base/content/browser-pocket-ru.properties
.......
 saveToPocketCmd.label = Сохранить страницу в Pocket
 saveToPocketCmd.accesskey = х
+saveLinkToPocketCmd.label = Сохранить ссылку в Pocket
+saveLinkToPocketCmd.accesskey = P

Looks like saveLinkToPocketCmd.accesskey uses latin letter "P" as accesskey for saveLinkToPocketCmd.label. Please use cyrillic letter, like "а" or "и".
There is an incorrect string for es-ES in dictionary.js:

-  mustbeconnected: "Comprueba que tienes conexión a Internet.",
+  mustbeconnected: "Compruebe que tiene conexión a Internet.",

Is this comment enough to get them fixed?
(In reply to Ricardo Palomares from comment #3)
 
> Is this comment enough to get them fixed?

Yes, I'll update this bug with a patch.
German (de) comments:

> +saveLinkToPocketCmd.label = Link in Pocket speichern
Link bei Pocket speichern

> +errorgeneric: "Beim Speichern des Links in Pocket ist ein Problem aufgetreten."
Beim Speichern des Links bei Pocket ist ein Fehler aufgetreten.

> + mustbeconnected: "Bitte versichere dich, dass du mit dem Internet verbunden bist."
This is – for whatever reason – informal address and only the second half of the string. Was this necessary for the string to fit?
„Sie müssen mit dem Internet verbunden sein, um Inhalte bei Pocket zu speichern. Bitte überprüfen Sie, ob Sie mit dem Internet verbunden sind und versuchen Sie es erneut.“ would be the complete string, „Bitte überprüfen Sie, ob Sie mit dem Internet verbunden sind“ is what has currently been translated.

> signupemail: "Mit E-Mail registrieren"
Mit E-Mail-Adresse registrieren

Archaeopteryx may have more later.
Only one addition for German:
Is: saving: "Speichern...",
Should be: saving: "Speichern…",
Flagging ja for feedback.
Flags: needinfo?(kohei.yoshino)
One correction in Japanese:

> mustbeconnected: "インターネットに接続されていることをご確認ください。"

(is enough polite in this context, so it) could be 

> mustbeconnected: "インターネットに接続されていることを確認してください。"

Other changes are LGTM.
Flags: needinfo?(kohei.yoshino)
Attached patch Patch v.2 (obsolete) — Splinter Review
Patch against current mozilla-central, now that bug 1162713 and bug 1164161 have already landed.

This takes care of everything noted here (except 2 German changes), as well as 2 changes for Japanese that I missed when bug 1161843 was reopened.
Attachment #8605486 - Attachment is obsolete: true
(In reply to Michael 'Coce' Köhler from comment #5)

> > + mustbeconnected: "Bitte versichere dich, dass du mit dem Internet verbunden bist."
> This is – for whatever reason – informal address and only the second half of
> the string. Was this necessary for the string to fit?
> „Sie müssen mit dem Internet verbunden sein, um Inhalte bei Pocket zu
> speichern. Bitte überprüfen Sie, ob Sie mit dem Internet verbunden sind und
> versuchen Sie es erneut.“ would be the complete string, „Bitte überprüfen
> Sie, ob Sie mit dem Internet verbunden sind“ is what has currently been
> translated.
> 
> > signupemail: "Mit E-Mail registrieren"
> Mit E-Mail-Adresse registrieren

I know the "-Adresse" got trimmed for space reasons (one of the Pocket developers is German, so this isn't as indiscriminate as it might seem. ;-). Not sure what happened with the other string -- it's not in a particularly constrained context (even the English string is fairly long)

Michael: to be clear, are you suggesting we either use the complete string or „Bitte überprüfen
Sie, ob Sie mit dem Internet verbunden sind“ as an improved short string?

Nate, I assume maicki trimmed these?
Flags: needinfo?(nate)
Flags: needinfo?(coce)
(In reply to Justin Dolske [:Dolske] from comment #10)

> I know the "-Adresse" got trimmed for space reasons (one of the Pocket
> developers is German, so this isn't as indiscriminate as it might seem. ;-).

As ever, space constraints suck, and without the „-Adresse“ part the string doesn’t really make sense (imho). „E-Mail“ is the message and „E-Mail-Adresse“ is the address. The former is probably not used for registration while the latter is. Oh well.


> Michael: to be clear, are you suggesting we either use the complete string
> or „Bitte überprüfen Sie, ob Sie mit dem Internet verbunden sind“ as an
> improved short string?

Yes.
Flags: needinfo?(coce)
Attached patch Patch v.3Splinter Review
Urk, forgot this was still in flight.
Assignee: nobody → dolske
Attachment #8606859 - Attachment is obsolete: true
Attachment #8608798 - Flags: review?(jaws)
Attachment #8608798 - Flags: review?(jaws) → review+
Comment on attachment 8608798 [details] [diff] [review]
Patch v.3

Approval Request Comment
[Feature/regressing bug #]: 
[User impact if declined]: String adjustments
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: just a string change
[String/UUID change made/needed]: n/a - strings are hardcoded.
Attachment #8608798 - Flags: approval-mozilla-release?
Attachment #8608798 - Flags: approval-mozilla-beta?
Attachment #8608798 - Flags: approval-mozilla-aurora?
Comment on attachment 8608798 [details] [diff] [review]
Patch v.3

No risk & important. Taking it.
Attachment #8608798 - Flags: approval-mozilla-release?
Attachment #8608798 - Flags: approval-mozilla-release+
Attachment #8608798 - Flags: approval-mozilla-beta?
Attachment #8608798 - Flags: approval-mozilla-beta+
Attachment #8608798 - Flags: approval-mozilla-aurora?
Attachment #8608798 - Flags: approval-mozilla-aurora+
Blocks: Pocket
Priority: -- → P3
Flags: qe-verify-
https://hg.mozilla.org/mozilla-central/rev/59c302146319
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: needinfo?(nate)
You need to log in before you can comment on or make changes to this bug.