11647 - Wallet fillin doesn't work

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Stephen P. Morse]

Go to edit/wallet/samples and click on here.  Fill in first and last name.  Save
form and answer yes when it asks if you want data entered into wallet.

Then go to edit/wallet/samples again and this time click on amazon.  Do a
fill-in (either safe fill or quick fill) from edit/wallet submenu.  Nothing gets
filled in.

Comment 1

[Stephen P. Morse]

OK, problem is that I downloaded the wrong files from the server.  There are
three files that I need which contain the mapping tables.  Unfortunately I
downloaded the URL each time although I stored it on three different files on
the user's machine.

Fix is trivial -- simply changing the name of the URL on the second two download
calls.  It's a two-line change in wallet.cpp.  Guarenteed not to break anything
else.  Now I need to get permission to check this in to the frozed M9 build.

Comment 2

[Paul MacQuiddy]

Jay, this is the problem you are seeing.

Steve, will this fix the problem with only the last name filling in if you
SafeFormFill on the same Here page, or is that a different problem.

Comment 3

[Stephen P. Morse]

It will fix a whole lot of problems because all bets are off when the mapping
tables are screwed up.  So it might fix that one as well.  Unfortunately I can't
say for sure because I was unable to reproduce that particular one.

Comment 4

[Stephen P. Morse]

Received permission from Chris Hofmann.  Fix checked in.

Comment 5

[Paul MacQuiddy]

this test case now works perfecto with 8/12 builds on linux, but nothing is
filled in with 8/12 windows, even though the safe form fill dialogue is filled
out correctly when I hit OK, nothing gets filled into the name field! This may
actually be a different bug, but the result is the same. Re-opening


And as we know, this is broken on Mac because the tables are not downloaded.

Comment 6

[Stephen P. Morse]

This really has me puzzled for two reasons.  First, it still works for me.  I
pulled and built a tree at about midnight last night.  Works fine.

Second, I don't understand how you could possible be testing this.  The safe
form-fill dialog that I see has the OK/CANCEL buttons off the bottom of the
screen and inaccesible (not even any scroll bars).  This is a separate bug that
has already been reported (bug 10406).  So without special hackery, it was not
even possible for me to run this test.  The special hackery that I had to do was
change a frame size in WalletPreview.html and then I could access my buttons.
But obviously you (paulmac) didn't do this hackery, so how are you able to run
this test?

Comment 7

[Jay Patel [:jay]]

Morse,I think the build Paul and I are running opens up a dialog for Safe Form
Fill that has the OK and Cancel buttons visible (barely noticeable) at the very
bottom of the window.  I can actually click those buttons if i carefully move
the mouse over them (without touching the border of the window).  I can do this
on all 3 platforms as of 8/12.

Comment 8

[Stephen P. Morse]

Strange that you can do that and I can't.  My windows build, which I pulled last
night at midnight, definitely doesn't let me see any part of the OK or CANCEL
buttons.  I tried both debug and optimized builds.

Comment 9

[Stephen P. Morse]

Ah, it probably has to do with screen resolution.  That would explain why it
draws slightly differenly on you screen than on mine.  OK, that mystery solved.
But now for the big question -- why is the fill-in working fine for me and not
for you.

Comment 10

[Jay Patel [:jay]]

Autofill works fine if the page has the same "types" of fields as i have already
entered into my wallet.  For instance if i goto the wallet info page and save my
first, last, middle, and nickname...i can autofill all those names into that
exact page, but if i go to the amazon page and try to autofill, it gives me the
message that there are no fields to autofill (because i don't have a "name" type
saved in my wallet.  A while back, when i filled in the first and last name on
the wallet info save page, apprunner would automatically know to combine the 2
and make new type "name" = "name.first name.last".  So auto fill works fine (it
fills in all fields that match what you have saved), but it does not know how to
fill in a "name" field.

Comment 11

[Jay Patel [:jay]]

Actually, safe form fill works on amazon.com page too...I just tried it with
today's build 8/13 and it worked!  The only problem now is that the window is
still too small (or not displayed correctly) to show the ok and cancel buttons
completely (Bug 10406).  Resolving this bug FIXED.

Comment 12

[Stephen P. Morse]

I understood the description of the problem and indeed was using data saved
in one form to prefill another form.  And I am not seeing this problem -- name
info entered on the wallet info page is being correctly placed on the amazon
page.

OK, I see from your last comment that you are finally seeing the same thing that
I am seeing.  Glad we can close this out.  Don't understand why you were seeing
something different yesterday.

Comment 13

[Paul MacQuiddy]

verified working OK now.

I won't hurt my brain and try to figure out why this wasn't working for us
before.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/718f52b90f25
[components] Close https://github.com/mozilla-mobile/android-components/issues/11647: Remove lib-push-amazon component