Closed
Bug 1164722
Opened 10 years ago
Closed 10 years ago
Temporarily disable Notification's RTL tests
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(2 files)
In order to fix bug 1137593 we need to disable some tests, land the gecko patch, land the gaia patch, reenable the tests.
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8605584 [details] [review]
[gaia] zbraniecki:1164722-temporarily-disable-notification-rtl-tests > mozilla-b2g:master
Kevin, can you r? this for me. I need to disable those tests to land the Gecko patch and then gaia patch in bug 1137593.
I'll reenable them when those two are in.
Attachment #8605584 -
Flags: review?(kgrandon)
Comment 3•10 years ago
|
||
Comment on attachment 8605584 [details] [review]
[gaia] zbraniecki:1164722-temporarily-disable-notification-rtl-tests > mozilla-b2g:master
Seems ok to me. I assume you have tested that these tests pass with your gecko and gaia work together?
Attachment #8605584 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Yes, I tested it locally and they do.
Assignee | ||
Comment 5•10 years ago
|
||
Commit: https://github.com/mozilla-b2g/gaia/commit/5e4041cc2db39be8e265cb646a43591bbb4ef100
I'll keep this bug open and back out the patch when the patches from bug 1137593 land.
Updated•10 years ago
|
Assignee: nobody → gandalf
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Commit: https://github.com/mozilla-b2g/gaia/commit/ed5a68e36aa3320236f8e6450b2cf234450e6e95
Merge: https://github.com/mozilla-b2g/gaia/commit/97dc139f1a690224e98533a86526c4165eed1db5
Reenabled!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•