Avoid overwriting COD files

VERIFIED FIXED in mozilla0.9.4

Status

--
major
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: namachi, Assigned: namachi)

Tracking

Trunk
mozilla0.9.4
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Fix in Trunk and 0.9.4 Branch)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
With the MOZ_CODINFO is set I am able to generate COD files for the product. But,
for each source file it is writing the COD file name as {module}.cod  instead
of {source file}.cod. 

  I have a patch which should fix this problem.

Shiva
(Assignee)

Comment 1

17 years ago
Created attachment 63016 [details] [diff] [review]
Fix to avoid overwriting cod files with the same name.

When MOZ_CODINFO is set the mozilla build system creates COD files(Source with
assembly information) this helps in find the proper functionname, source file
and 
line number of the topcrash and subsequent full stack trace information. This
feature is used by both Mozilla Application and Embedding Applications.

 Currently the codfile name is used as modulename and it is one per module but
the cod file has to be generated one for each source. With this fix code file
will be generated for each source file and avoid over writing.

cls/leaf - review ?
dveditz - super-review ?
marek - approval ?
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: edt0.9.4
Whiteboard: has patch, needs review and super review.
Target Milestone: --- → mozilla0.9.4

Comment 2

17 years ago
Jud -- Need some traction here.

Comment 3

17 years ago
Comment on attachment 63016 [details] [diff] [review]
Fix to avoid overwriting cod files with the same name.

r=leaf
Attachment #63016 - Flags: review+
Comment on attachment 63016 [details] [diff] [review]
Fix to avoid overwriting cod files with the same name.

sr=dveditz
Attachment #63016 - Flags: superreview+

Comment 5

17 years ago
updating summary, this has sr and r now. shiva, can you drive this into 0.9.4,
then put "fixed0.9.4" in the keyword field once it's landed there?
Keywords: edt0.9.4 → edt0.9.4+
Whiteboard: has patch, needs review and super review.
(Assignee)

Comment 6

17 years ago
Fix is in the Trunk. Tomorrow I will check it into 0.9.4 Branch.
Whiteboard: Fix in Trunk.

Comment 7

17 years ago
When do expect to check into 094?
(Assignee)

Comment 8

17 years ago
Fix checked into 0.9.4 also. 
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Keywords: fixed0.9.4
Resolution: --- → FIXED
Whiteboard: Fix in Trunk. → Fix in Trunk and 0.9.4 Branch

Comment 9

16 years ago
verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.