Closed Bug 1164784 Opened 8 years ago Closed 8 years ago

Clean up CSS code duplication for "Start recording Performance" button

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed, firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(2 files)

Screenshot
16.21 KB, image/png
Details
Patch
3.40 KB, patch
jsantell
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Possible fixes :
- Use the devtools-toolbarbutton class and the standalone attribute and remove current hardcoded code (seems best to me to do this)
- Add -moz-appearance: none to the hardcoded code
Attached image Screenshot — 

    
    

    
  
I think the fix in bug 1163384 will also work here -- was this on aurora?

    
    

    
  
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> I think the fix in bug 1163384 will also work here
It surely will, although there is still code duplication.

    
    

    
  
I mean does bug 1163384 fix this issue? Can we turn this bug into remove duplicated styling for those button via standalone attribute?
Whiteboard: [devedition-40]

    
    

    
  
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> I mean does bug 1163384 fix this issue?
I can't test as this isn't on latest nightly yet. But manually adding the devtools-toolbarbutton class on the button using the Browser Toolbox works.

> Can we turn this bug into remove duplicated styling for those button via standalone attribute?
Yes.

    
    

    
  
bug 1163384 fixed this.
Summary: "Start recording Performance" has native look on Windows → Clean up CSS code duplication for "Start recording Performance" button

    
    

    
  
Removing from perf-tool-v2
No longer blocks: perf-tool-v2
Whiteboard: [devedition-40] → [good first bug][lang=css]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

        Attachment #8608964 -
        Flags: review?(jsantell)

        Attachment #8608964 -
        Flags: review?(jsantell) → review+

    
  
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d64a8ec60cfe
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox41:
          affected → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 41
Flags: qe-verify-

    
    

    
  
Comment on attachment 8608964 [details] [diff] [review]
Patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

        Attachment #8608964 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

    
    

    
  
Comment on attachment 8608964 [details] [diff] [review]
Patch

Change approved to skip one train as part of the spring campaign.

        Attachment #8608964 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.