1164822 - OS.File.remove does not honor the ignoreAbsent option

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Alessio Placitelli [:Dexter]]

Calling |OS.File.remove(NON_EXISTING_FILE_PATH, {ignoreAbsent: false})| on a non existing file path does not throw (it should, as ignoreAbsent was introduced by bug 857077).

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1164822.patch

This fixes the problem: the options were not being passed around.

Also, I've noticed that "\toolkit\components\osfile\tests\mochi\worker_test_osfile_front.js" contains the |test_remove_file()| test which appears to be broken: without this patch, the first check doesn't fail.

Yoric, do you have any clue why that test doesn't fail?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8605826 [details] [diff] [review]
bug1164822.patch

Review of attachment 8605826 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Could you add a test in the xpcshell/ directory?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

(In reply to Alessio Placitelli [:Dexter] from comment #1)
> Yoric, do you have any clue why that test doesn't fail?

Well, your fix fixes the main thread API. That test tests the worker API, which already worked.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: part 2 - add test coverage

Thanks Yoric, this adds test coverage for the ignoreAbsent flag.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8607012 [details] [diff] [review]
part 2 - add test coverage

Review of attachment 8607012 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/tests/xpcshell/test_remove.js
@@ +25,5 @@
> +  try {
> +    yield OS.File.remove(absent_file_name, {ignoreAbsent: false});
> +  } catch (ex) {
> +    exception = ex;
> +  }

You should use `Assert.rejects`.

Comment 6

[Alessio Placitelli [:Dexter]]

Attachment: part 2 - add test coverage - v2

Thank you Yoric!

Here's the try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d970dac3bbee

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2f729ee97af9
https://hg.mozilla.org/integration/fx-team/rev/c40ca2a73105

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2f729ee97af9
https://hg.mozilla.org/mozilla-central/rev/c40ca2a73105