laglog sometimes chokes on null

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We rely on `SELECT NOW(), client_addr, sent_location, replay_location FROM pg_stat_replication` to get information about how far behind the replica is of the leader. Sometimes when Postgres is under extreme load these numbers come back as NULL thus breaking the laglog job with a misleading AttributeError when it tries to split a None. 

Better to log and avoid.
(Assignee)

Updated

3 years ago
Assignee: nobody → peterbe
Status: NEW → ASSIGNED

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/23076bac66bb901acf9183b70bca64ca265b2a43
fixes bug 1164922 - laglog sometimes chokes on null

https://github.com/mozilla/socorro/commit/1ef6727801a275f1601d02d05b7acc26ecc9a45f
Merge pull request #2787 from peterbe/bug-1164922-laglog-sometimes-chokes-on-null

fixes bug 1164922 - laglog sometimes chokes on null

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.