1164943 - Add support for Windows ec2 config.xml

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Amy Rich [:arr] [:arich]]

This is part of bug 1166448.

Comment 2

[Amy Rich [:arr] [:arich]]

My mistake, this is for instantiation from the golden AMI. This work is still necessary.

Comment 3

[Mark Cornmesser [:markco] OOO 2024/04/15]

Attachment: BUG1164943.patch

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8629086 [details] [diff] [review]
BUG1164943.patch

Review of attachment 8629086 [details] [diff] [review]:
-----------------------------------------------------------------

r+ aside from a cosmetic change

::: modules/hardware/manifests/ec2_config.pp
@@ +7,5 @@
> +    # The file below does not contain the Mozilla license header because commented portion breaks the ec2 config service 
> +    case $::fqdn {
> +        /.*\.releng\.(use1|usw2)\.mozilla\.com$/: {
> +            # This config file enables/disables various plugin execution by the EC2 config service
> +            # The file below does not contain the Mozilla license header because commented portion breaks the ec2 config service

duplicated comment

Comment 5

[Mark Cornmesser [:markco] OOO 2024/04/15]

Comment on attachment 8629086 [details] [diff] [review]
BUG1164943.patch

Duplicate comment removed. 

 https://hg.mozilla.org/build/puppet/rev/705481238365