MozReview request #4487 gives an HTTP 500 error

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bokeefe, Assigned: mdoglio)

Tracking

Details

(URL)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
I can't tell exactly what broke, but something I did caused MozReview to start returning an HTTP 500 error for https://reviewboard.mozilla.org/r/4487/.

I did the following:
- Push a new batch of csets
- Edit the reviewers
- Click around on the child reviews (making sure the csets looked right)
- Trigger a try build with the autoland button (I hadn't published yet)
- Autoland returned an error that rev e0b684a22cf8 wasn't available (I'm guessing because this is a c-c review?)
- I attempted to publish the review
- MozReview told me my Bugzilla token was invalid or had expired, and I should log in again
- I logged out, and logged in again
- On the dashboard, the review showed as published
- I clicked the link for the parent review (above), and got a 500 error.

I can still get to the child reviews (and, actually, the diff page for the parent review), so it's just the one page that's broken.
Traceback (most recent call last):
File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_django.py", line 497, in wrapper return wrapped(*args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/accounts/decorators.py", line 23, in _check return view_func(*args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/site/decorators.py", line 35, in _check return view_func(request, local_site=local_site, *args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/views.py", line 663, in review_detail changedesc.fields_changed[field_id])
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/mozreview-0.1a0-py2.6.egg/mozreview/fields.py", line 129, in get_change_entry_sections_html 'rendered_html': mark_safe(self.render_change_entry_html(info)),
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/mozreview-0.1a0-py2.6.egg/mozreview/fields.py", line 134, in render_change_entry_html autoland_id = int(info['new'][0])
TypeError: int() argument must be a string or a number, not 'NoneType'
Priority: -- → P1
(Assignee)

Updated

3 years ago
Assignee: nobody → mdoglio
Of interest for debugging, the changedescriptions related to this issue:
https://reviewboard.mozilla.org/admin/db/changedescs/changedescription/12561/
Includes: u'p2rb.autoland_try': {u'new': [None], u'old': [66]}

https://reviewboard.mozilla.org/admin/db/changedescs/changedescription/12579/
Includes: u'p2rb.autoland_try': {u'new': [66], u'old': [None]}

https://reviewboard.mozilla.org/admin/db/changedescs/changedescription/8649/
Doesn't include any autoland information

Also, checking the API it appears the autland_try entry is empty.
Status: NEW → ASSIGNED

Comment 3

3 years ago
Should someone manually hack up the DB to unblock this review series being in a messed up state?
(Assignee)

Comment 4

3 years ago
I don't think we need to modify the db, mozreview should handle that error more gracefully. Patch coming soon
(Assignee)

Comment 5

3 years ago
Created attachment 8607498 [details]
MozReview Request: bz://1164965/mdoglio

/r/9037 - mozreview: catch tryfield render error (Bug 1164965)

Pull down this commit:

hg pull -r 840a08839ce5d9df9ed57c99116771f3e49402d7 https://reviewboard-hg.mozilla.org/version-control-tools/
Attachment #8607498 - Flags: review?(smacleod)

Comment 6

3 years ago
glandium had a 500 on /r/9081. Server logs show same stack trace.

Comment 8

3 years ago
Comment on attachment 8607498 [details]
MozReview Request: bz://1164965/mdoglio

https://reviewboard.mozilla.org/r/9035/#review7751

I'll happily steal this review. Please land this ASAP so it can get deployed.
Attachment #8607498 - Flags: review+

Updated

3 years ago
Duplicate of this bug: 1166604
Attachment #8607498 - Flags: review?(smacleod)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

3 years ago
Comment on attachment 8607498 [details]
MozReview Request: bz://1164965/mdoglio
Attachment #8607498 - Attachment is obsolete: true
Attachment #8620299 - Flags: review+
(Assignee)

Comment 11

3 years ago
Created attachment 8620299 [details]
MozReview Request: mozreview: catch tryfield render error (Bug 1164965)
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.