Closed Bug 1164971 Opened 10 years ago Closed 10 years ago

.git/hooks/pre-commit: Syntax error

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sfoster, Unassigned)

Details

(Keywords: regression)

The new pre-commit hook uses bash-specific syntax, resulting in an error: .git/hooks/pre-commit: 156: .git/hooks/pre-commit: Syntax error: "(" unexpected (expecting "fi") This is a result of the changes in bug 1164346 I'm using stock Ubuntu 14.04, where /bin/sh links to dash. This currently prevents me (and presumably others) from committing in this repo without redirecting /bin/sh to another shell or using the --no-verify override.
Backing out 1164346 fixed it, that has been re-opened. You just need to do a `make` in gaia to get the updated tools/pre-commit file copied over to .git/hooks/pre-commit to pick up the changes.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.