.git/hooks/pre-commit: Syntax error

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sfoster, Unassigned)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
The new pre-commit hook uses bash-specific syntax, resulting in an error: .git/hooks/pre-commit: 156: .git/hooks/pre-commit: Syntax error: "(" unexpected (expecting "fi")

This is a result of the changes in bug 1164346

I'm using stock Ubuntu 14.04, where /bin/sh links to dash. This currently prevents me (and presumably others) from committing in this repo without redirecting /bin/sh to another shell or using the --no-verify override.
(Reporter)

Comment 1

3 years ago
Backing out 1164346 fixed it, that has been re-opened. You just need to do a `make` in gaia to get the updated tools/pre-commit file copied over to .git/hooks/pre-commit to pick up the changes.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.