Closed Bug 1164982 Opened 5 years ago Closed 5 years ago

Add a telemetry probe tracking MAX_PAUSE but only while animating

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

During normal system usage, our slice request time varies between 10 and 40ms, so seeing that our typical slice times in practice are 40ms doesn't really tell us how well we're doing during animations. This new telemetry probe should allow us to tell if our typical pause of 40ms is because most slice requests are for 40ms or if we're just usually failing to hit 10ms.
Adds a telemetry probe to track slice budgets when time budgeted, and a probe to track our slice times when the time budget is not expanded (e.g. animating).
Attachment #8615431 - Flags: review?(sphink)
Comment on attachment 8615431 [details] [diff] [review]
telemetry_max_pause_during_animation-v0.diff

Review of attachment 8615431 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good. In a perfect world, these would probably be keyed histograms: "all", "timed", "fast", "slow" or whatever. And maybe "work" if we ever use those. But given the current state of tooling, this seems wiser.
Attachment #8615431 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/46871501aaa3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.