1165007 - Datepicker for until data of non custom recurrence rule should be preset with event end date

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[[:MakeMyDay]]

STR:
1. Create a new event.
2. Select a future date for start and end (e.g. 14 days in future).
3. Select a non custom recurrence rule (Daily, Weekly,...).
4. Open daypicker to specify the end of the occurences.

Result:
The daypicker is preset with the current date.

Expected:
The end date specified when opening the day picker should be used to preset the daypicker.

Comment 1

[Decathlon]

Attachment: patch-v1

This is annoying when creating a recurring event starting from a month different than the current month.

This patch adds to the minimonth binding the ability to handle a third date other than "today" and "selected" to preset the datepicker. Without this date, the until-datepicker can show only "today" when "forever" is the "selected" date (default value for a new event).

Differently from the request in comment 0, I've used the start date of the event for the preset date because it is a lower bound for the until date.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8713379 [details] [diff] [review]
patch-v1

Review of attachment 8713379 [details] [diff] [review]:
-----------------------------------------------------------------

Decathlon, can you add a screenshot for this for ui-review?

::: calendar/resources/content/datetimepickers/datetimepickers.xml
@@ +300,5 @@
> +          <![CDATA[
> +            this.kMinimonth.extra = val;
> +          ]]>
> +        </setter>
> +      </property>

You can shorten this to:

<property name="extraDate"
          onget="return this.kMinimonth.extra"
          onset="this.kMinimonth.extra = val"/>

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8713379 [details] [diff] [review]
patch-v1

It doesn't matter if the start- or the end date of the event should be used. It gives always cases there the other would be better.

Comment 4

[Decathlon]

Attachment: Screenshot

Just for the record, this is the screenshot.

To highlight the start date is not strictly required for the bug, but since we have to handle it, a border could be useful to orient the user in the minimonth.

(In reply to Richard Marti (:Paenglab) from comment #3)
> It doesn't matter if the start- or the end date of the event should be used.
> It gives always cases there the other would be better.

Yes, you are right, but the start date it seems to me a more general reference.
Other than the lower bound for the until date, it could also helps to visually find the correct day when the user thinks in term of duration for the recurrence e.g. a daily event for two weeks, one month etc.

Comment 5

[Decathlon]

Attachment: patch-v2

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> You can shorten this to:
> 
> <property name="extraDate"
>           onget="return this.kMinimonth.extra"
>           onset="this.kMinimonth.extra = val"/>

done.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/e5a89cd5371467f3c189d8d2c2461b41881d5696
Bug 1165007 - Daypicker for end data of non custom recurrence rule should be preset with event end date r=philipp