1165012 - Socorro's auto-populated "Report this bug" link can create a bug-summary that's too long (so Bugzilla rejects it)

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Daniel Holbert [:dholbert]]

STR:
 0. Be logged in to bugzilla.mozilla.org.

 1. Visit https://crash-stats.mozilla.com/report/index/d5eb0ad3-1e00-42d4-a2ea-dd7372150512

 2. Click "Report this bug in... [Core]"

 3. Pick "ImageLib" as component (or anything, you just have to pick something) and click "Submit Bug".

ACTUAL RESULTS:
This Bugzilla error page:
{
The text you entered in the Summary field is too long (264 characters, above the maximum length allowed of 255 characters).
}

EXPECTED RESULTS:
Socorro should prepopulate the Summary field with an acceptable-to-bugzilla Summary string.


(NOTE: if anyone happens to successfully file a bug while testing this, you can dupe it to bug 1165009, which is the actual bug report for this crash [which I just filed, after hitting this issue & manually shortening the "Summary" field)

Comment 1

[Daniel Holbert [:dholbert]]

The autopopulated Summary field (provided by Socorro) is:
crash in mozilla::gfx::BaseRect<int, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits>, mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits>, mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>, mozilla::gfx::IntMarginTyped<mozilla::gfx::UnknownUnits...

Note that this has already been shortened and ellipsized. It looks like the *signature* (with the ellipsis) is exactly 255 characters. And then when 9 characters of "crash in " is prepended, that pushes us up to 264, which is too long for Bugzilla.

Comment 2

[Daniel Holbert [:dholbert]]

So Socorro is already doing some clamping to 255 characters -- but it's clamping too early, before "crash in " has been prepended. It needs to clamp after that has happened.

(Or, it needs to clamp to 246 instead of 255, so that we've got room to prepend 9 characters of "crash in ".)

Comment 3

[Robert Kaiser]

The current clamping is for being able to store the signature in 255 char PostgreSQL fields. We need to re-clamp (probably with a very dump truncation) when handing this over to Bugzilla. As we put the "full" 255-char signature into the Crash Signature field anyhow, the summary can be cut without danger.

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/2788

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d653b98132c61455b505e18e68ea3dea40192e2f
fixes bug 1165012 - strip "report this bug" summary

https://github.com/mozilla/socorro/commit/c1a962ca484f50c4c730ace7141dc4f9adb5500b
Merge pull request #2788 from peterbe/bug-1165012-strip-report-this-bug-summary

fixes bug 1165012 - strip "report this bug" summary