Closed
Bug 1165118
Opened 10 years ago
Closed 10 years ago
Provide a view similar to bugzilla's "Details", and also plain/text patch
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: smaug, Unassigned)
Details
I've got used to reviewing using bugzilla's "details", or in practice I pretty much always
open the patch in two tabs: one has bugzilla's "details", one has the plain patch as such.
Since mozreview doesn't provide really much to help my reviewing (for example it is not linkifying
code so that I could look easily for the callers of the relevant method, so still most of the reviewing time goes to
mxr'ing the relevant code), I'd prefer to be able to do reviews the same way as in bugzilla.
Right now whenever I get a mozreview review request, I download the patch and look at the patch file in an editor.
And then I mark r+/- in bugzilla, not in mr.
So, a view which doesn't split the changes to old(left)/new(right), but just have the changes with -+ in one view would be great, and
also a link to view the patch as plain/text in browser.
| Reporter | ||
Comment 1•10 years ago
|
||
(and yes yes, old grumpy reviewer stuck with his habits.)
Comment 2•10 years ago
|
||
I get what you're saying, but I don't think we can justify a big feature like this for such a specific use case. We can do other things you suggest, like linkifying code.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
| Assignee | ||
Updated•10 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•