Locale support for suggested sites

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: noteworthy)

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
The suggested sites list we ship is in English. We should make it localizable (and allow shipping different sites in other locales).
(Assignee)

Updated

4 years ago
tracking-fennec: --- → ?
(Assignee)

Comment 1

4 years ago
Is this going to be possible? Right now I just checked in a static list here (from Fennec with the AMO and Marketplace links removed):

https://github.com/mozilla/firefox-ios/blob/master/Client/Assets/suggestedsites.json

while I waited to see what the search engines group did. Sounds like we can do something similar to what they did here?
tracking-fennec: ? → +
Flags: needinfo?(francesco.lodolo)
http://hg.mozilla.org/mozilla-central/file/tip/mobile/locales/en-US/chrome/region.properties#l42

We're not currently localizing suggested sites at the moment, so I don't really have an answer to this question.

Technically they're localizable in region.properties, practically we never implemented any policy (what to accept, etc.) nor started accepting localizations for the ones shipping in en-US.
Flags: needinfo?(francesco.lodolo)

Comment 3

4 years ago
Darren, do content services have plans for suggested tiles on iOS? Also looping in mconnor.

I'm not convinced that we should tie the suggested sites to our update cycle.

Do we have any existing data processes to update iOS fx with server-provided data snippets?
(Assignee)

Comment 4

4 years ago
Currently there's not much infrastructure for pulling down snippets at runtime (we do pull from a local url, which should also work for a remote one, but that about it).

I assume we will sometime, but its not for v1.

Comment 5

4 years ago
@axel we currently do not have this on the roadmap.  Maybe in the future, but right now, Content Services is focused on desktop.

Updated

3 years ago
tracking-fxios: --- → +
(Assignee)

Comment 6

3 years ago
Going to make sure that the redirects work right right now. Also going to update the SUMO link to the iOS page in this bug.
Assignee: nobody → wjohnston
(Assignee)

Comment 7

3 years ago
Created attachment 8624770 [details] [review]
Update urls

This updates the urls to be local agnostic. It doesn't fix the titles though :(
Attachment #8624770 - Flags: review?(sarentz)
Comment on attachment 8624770 [details] [review]
Update urls

LGTM
Attachment #8624770 - Flags: review?(sarentz) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
tracking-fennec: + → ---
Whiteboard: noteworthy
You need to log in before you can comment on or make changes to this bug.