1165126 - docker-worker: Make artifact expiration optional, default to task.expires

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

As of the new queue (deployed end of Q1) we now have a "task.expires".
I suggest that we default artifact expiration to task.expires.

This will be the alternative to bug 1135833.

We do want to ability to set even shorter expiration.

Note, queue will not allow artifact to expire after "task.expires".

Comment 2

[Greg Arndt [:garndt]]

Attachment: https://github.com/taskcluster/docker-worker/pull/214

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8722235 [details] [review]
https://github.com/taskcluster/docker-worker/pull/214

Looks sound to me...

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/docker-worker

https://github.com/taskcluster/docker-worker/commit/0b306d5a72c050f091ffa02474faebe99da1f9c3
Merge pull request #214 from gregarndt/artifact_expiration

Bug 1165126 - Validate artifact expiration and allow artifact.expires to be optional

Comment 5

[Greg Arndt [:garndt]]

Merged, will go out with the next AMI deployments

https://github.com/taskcluster/docker-worker/commit/0b306d5a72c050f091ffa02474faebe99da1f9c3