1165160 - [Stingray] Marionette sendKeys method fails at dashboard app test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[yifan [:yifan][:yliao]]

When running dashboard marionette test, the sendKeys method fails due to focus issue.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

The root cause of this issue is that: we tries to send the keyevent too early before smart-system booted. Smart System has a mechanism to prevent unexpected keyboard behaviors. It blocks all keyboard events if the focus is wrong. The system is viewed as crashed if the focus is wrong. During the booting procedure, we may create a lot of UI and iframe. The focus is moved from booting logo to iframe once fully booted.

So, if a keyboard event is sent to an iframe too early, it is blocked.

This feature is done for partner but not picked. So, I will turn it off by default but partner can turn it on through settings key, focusmanager.autofix.enabled.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1165160-turn-off-fallback-by-default > mozilla-b2g:master

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8606067 [details] [review]
[gaia] huchengtw-moz:bug-1165160-turn-off-fallback-by-default > mozilla-b2g:master

Please review this patch. The default behavior is to turn off the catcher. But we can still turn it on through settings key.

Comment 4

[yifan [:yifan][:yliao]]

Comment on attachment 8606067 [details] [review]
[gaia] huchengtw-moz:bug-1165160-turn-off-fallback-by-default > mozilla-b2g:master

Test for dashboard passes. Thanks!

Comment 5

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8606067 [details] [review]
[gaia] huchengtw-moz:bug-1165160-turn-off-fallback-by-default > mozilla-b2g:master

looks good to me

Comment 6

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#2-Z9D8zRRvKrxXkK9Fbhig

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 7

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30074

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 8

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30074

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 9

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30074

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 10

[Kevin Grandon :kgrandon]

Trying again due to tree closures. Sorry about the spam here.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3b51d18fe5ca5aae9fc523947c0dfd6874a2a6c2