Closed Bug 1165172 Opened 5 years ago Closed 5 years ago

Table row progression and vertical writing-modes

Categories

(Core :: Layout: Tables, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bugzilla, Assigned: jfkthame)

References

Details

(Keywords: testcase)

Attachments

(1 file)

Vendor-prefixed table row progression (in vertical writing-mode) tests
----------------------------------------------------------------------

vertical-rl - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-002.xht

vertical-lr - table rows progression (basic)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-003.xht

vertical-rl - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-004.xht

vertical-lr - table rows progression and colspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-005.xht

vertical-rl - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-006.xht

vertical-lr - table rows progression and rowspan
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-007.xht



Expected result for those 6 tests
---------------------------------

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/multicol-count-002-ref.xht


Firefox 41.0a1 buildID=20150513191426 fails those 6 tests.


Notes
-----

- Those 6 tests have been submitted to Writing-modes test suite
- IE11, Chrome 42.0.2311.152 and Chrome 44.0.2398.0 pass those 6 tests
- I use Linux 3.13.0-52-generic x86_64, Qt: 4.8.6, KDE 4.13.3; Kubuntu (trusty) 14.04.02 LTS
- I've searched for duplicates and did not find any.
Blocks: 1077521
Keywords: testcase
OS: Unspecified → All
Hardware: Unspecified → All
Prince 10.1 also passes the 3 vertical-rl tests... albeit it seems to misplace the table box inside <body>.
2 additional
vendor-prefixed table row progression (in vertical writing-mode) tests
----------------------------------------------------------------------

vertical-rl - table rows progression (thead, 2 tbodies, tfoot)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/row-progression-008.xht

vertical-lr - table rows progression (thead, 2 tbodies, tfoot)
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/row-progression-009.xht



Expected result for those 2 tests
---------------------------------

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/multicol-count-002-ref.xht


Firefox 41.0a1 buildID=20150513191426 fails those 2 tests.


Notes
-----

- Those 2 tests have been submitted to Writing-modes test suite
- IE11, Chrome 42.0.2311.152 and Chrome 44.0.2398.0 pass those 2 tests
- Prince 10.1 passes the vertical-rl test (row-progression-008) albeit it misplaces the anonymous table box.
Looks like these tests pass now. I think there'll be a bit of antialiasing fuzz needed, due to the use of Ahem glyphs, but aside from that they look good locally; waiting to see what tryserver thinks.
Attachment #8626624 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
All tests in comment 0 and comment 2 now pass with Firefox 41.0a1 buildID=20150626030206 .

Although... 

there seems to be an incomplete reflow issue in wm-row-progression-002 test and I can reliably reproduce it 100%.

http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-002.xht

The yellow "PASS" word is correctly constructed, rendered... but it is offset toward the left by 2em. After refreshing (with *F5* but not with Ctrl+F5) the page, the correct horizontal position is achieved.

Steps to reproduce this left offset issue:
1- Load
http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-progression-002.xht

2- Do Ctrl+F5

I can load a screenshot (actual results) if needed.

I get expected results with F5.

Gérard
(In reply to Gérard Talbot from comment #5)
> All tests in comment 0 and comment 2 now pass with Firefox 41.0a1
> buildID=20150626030206 .
> 
> Although... 
> 
> there seems to be an incomplete reflow issue in wm-row-progression-002 test
> and I can reliably reproduce it 100%.
> 
> http://www.gtalbot.org/BrowserBugsSection/CSS3WritingModes/wm-row-
> progression-002.xht
> 
> The yellow "PASS" word is correctly constructed, rendered... but it is
> offset toward the left by 2em. After refreshing (with *F5* but not with
> Ctrl+F5) the page, the correct horizontal position is achieved.

This will be fixed by bug 1177600, IIRC.
> This will be fixed by bug 1177600, IIRC.

Okay noted, Jonathan.

Right now, all 4 vertical-rl tests in this bug are affected.
Comment on attachment 8626624 [details] [diff] [review]
Tests from Gérard Talbot for table row progression in vertical writing-modes

Review of attachment 8626624 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the necessary fuzzing
Attachment #8626624 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/5bf907b87954
https://hg.mozilla.org/mozilla-central/rev/148fe775b1d4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.