1165182 - [bluetooth2] LeScan keeps scanning even after app stopped

Status: RESOLVED FIXED

Description

[elin]

If I call startLeScan in my app, 
and then stop my app from WebIDE or task manager without calling stopLeScan first,
it will keep scanning until I disable bluetooth.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Created attachment 8607387 [details] [diff] [review]
Stop LE scans when Bluetooth adapter is disconnected from its owner. (v1)

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8607387 [details] [diff] [review]
Stop LE scans when Bluetooth adapter is disconnected from its owner. (v1)

Review of attachment 8607387 [details] [diff] [review]:
-----------------------------------------------------------------

I'm sorry for the delay here.
The patch looks good to me, thanks.

::: dom/bluetooth/bluetooth2/BluetoothAdapter.cpp
@@ +340,5 @@
>  BluetoothAdapter::DisconnectFromOwner()
>  {
>    DOMEventTargetHelper::DisconnectFromOwner();
>  
> +  Cleanup();

nit: remove the empty line before this line.

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

Created attachment 8610310 [details] [diff] [review]
Stop LE scans when Bluetooth adapter is disconnected from its owner. (v2)

- revise previous patch based on #comment 2
- add reviewer's name to commit message

Thank Jocelyn for reviewing the patch.

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

Skip the "Pushing to Try" procedure since Bluetooth API v2 hasn't be covered by tinderbox.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f2fb0ce117eb

Comment 6

[elin]

I tried this patch and it works!
Thanks a million!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2fb0ce117eb