1165232 - [L10n][Settings]Serbian Cyrillic: The heading at "Enter certificate nick name" view is truncated.

Status: VERIFIED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: Serbian Cyrillic_Enter certificate nick name.png

[1.Description]:
[L10n][Flame2.1&2.2][Settings]Serbian Cyrillic:Import Wi-Fi certificate and select a certificates file to enter , then the heading at "Enter certificate nick name" view is truncated.
See attachment: Serbian Cyrillic_Enter certificate nick name.png

[2.Testing Steps]: 
Precondition:Set system language as Serbian Cyrillic and there're Wi-Fi certificates file in device storage.
1.Launch Settings app
2.Enter "Wi-Fi" view.
3.Tap "Manage Certificates"
4.Tap "Import Certificate" and select a certificates file.

[3.Expected Result]: 
4. The heading at "Enter certificate nick name" view should not be truncated.

[4.Actual Result]: 
4. The heading at "Enter certificate nick name" view is truncated.

[5.Reproduction build]: 
Device: Flame 2.1 user (Affected)
Build ID               20150514001201
Gaia Revision          c80865cb0bf73f1b97defbc646083b404feb3ac4
Gaia Date              2015-05-12 06:26:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/23eb9df75991
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150514.035617
Firmware Date          Thu May 14 03:56:27 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 2.2 user (Affected)
Build ID               20150514002501
Gaia Revision          aac58a063e3e6acae6ba77fe4cec224fb69450bc
Gaia Date              2015-05-13 12:59:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/47f1ced9f1d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150514.040432
Firmware Date          Thu May 14 04:04:43 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Marko Andrejić]

We can shorten string to "Унесите име серт." if it can fit.

I can not check this on my Flame device since I don't have any certificates file neither I see option to add them.

Comment 2

[Vanja Tumbas [:civas]]

> We can shorten string to "Унесите име серт." if it can fit.

Hey Marko that will not work, we will still be missing one character.

hmm sr-Cyrl version is 4 characters shorter than en version:
https://transvision.mozfr.org/?recherche=apps%2Fsettings%2Fsettings.properties%3AenterCertificateNickname&repo=gaia&sourcelocale=en-US&locale=sr-Cyrl&search_type=entities

I have a hunch that en version is also broken, Marko please check.

Comment 3

[Marko Andrejić]

Attachment: Untitled-1.jpg

Englsih 2.1 is fine, but 2.2 is broken.

Comment 4

[Marko Andrejić]

Attachment: changes1.diff

Please review this patch.

Comment 5

[Vanja Tumbas [:civas]]

Comment on attachment 8606311 [details] [diff] [review]
changes1.diff

Review of attachment 8606311 [details] [diff] [review]:
-----------------------------------------------------------------

great

Comment 6

[Vanja Tumbas [:civas]]

Landed:
* gaia https://hg.mozilla.org/gaia-l10n/sr-Cyrl/rev/97f9a08dc44e
* 2.1  http://hg.mozilla.org/releases/gaia-l10n/v2_1/sr-Cyrl/rev/a05bac55df2a

Comment 7

[Vanja Tumbas [:civas]]

Notes:
* 2.1 is fixed

* 2.2 header is shorten. It is still missing one character in order not to be truncated.
Anyway header in English version is also broken (check comment3). So when UI is fixed sr-Cyrl will also be fixed ;)

Comment 8

[Marko Andrejić]

Attachment: verified.jpg

Here's a verified strings on my Flame device.