1165281 - Enable eslint rules for Loop: whitespace related

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Enable some more eslint rules for Loop. Rules to enable in this bug:

* key-spacing - no space before :, one space after for object properties 
* no-spaced-func - no spaces between the function identifier and application
* no-wrap-func - no wrapping of non-IIFE statements in parens (currently nothing hits this)

To enable the rule, remove the line from browser/components/loop/.eslintrc and save it.

Then you can run eslint in the browser/components/loop directory with:

  eslint  --ext .js --ext .jsm --ext .jsx .

The errors listed in the output are to be fixed.

If there's errors in a .js file that has an associated .jsx file, then fix the jsx file and run the react tools to generate the .js file (https://wiki.mozilla.org/Loop/Development#Developing).

If you need more help setting up eslint, see https://wiki.mozilla.org/Loop/Development#Additional_Requirements

Information about the eslint rules can be found here:

http://eslint.org/docs/rules/

Comment 1

[Aaron Raimist [:aaronraimist]]

Attachment: bug1165281_key-spacing

Comment 2

[Aaron Raimist [:aaronraimist]]

Attachment: bug1165281_no-spaced-func

This patch works for every error except one in modules/MozLoopPushHandler.jsm. I can't figure out how to fix it.

Comment 3

[Aaron Raimist [:aaronraimist]]

Attachment: bug1165281_no-wrap-func

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8613268 [details] [diff] [review]
bug1165281_key-spacing

Review of attachment 8613268 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks for the patch!

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8613269 [details] [diff] [review]
bug1165281_no-spaced-func

Review of attachment 8613269 [details] [diff] [review]:
-----------------------------------------------------------------

Regarding the MozLoopPushHandler.jsm issue. It isn't quite obvious, the start of the current code is:

      throw new Error("PushSocket: missing required parameter(s):"
                      (pushUri ? "" : " pushUri") +

There's a missing '+' on the end of the line. Adding that seems to be enough to fix the issue. Javascript seems reasonably happy with the current form (or we just haven't hit it yet), but I think its safest to fix it anyway.

Could you update the patch to add the fix please? Then we can get these landed together.

Comment 6

[Aaron Raimist [:aaronraimist]]

Attachment: bug1165281_no-spaced-func

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8613594 [details] [diff] [review]
bug1165281_no-spaced-func

Review of attachment 8613594 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 8

[Aaron Raimist [:aaronraimist]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f28737d9eb0b

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ae8d9ec79f08
https://hg.mozilla.org/integration/fx-team/rev/185da51e4e80
https://hg.mozilla.org/integration/fx-team/rev/f0f43e99cd4b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae8d9ec79f08
https://hg.mozilla.org/mozilla-central/rev/185da51e4e80
https://hg.mozilla.org/mozilla-central/rev/f0f43e99cd4b