Closed
Bug 1165306
Opened 9 years ago
Closed 9 years ago
Clean up ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
4.94 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8606267 [details] [diff] [review] patch Review of attachment 8606267 [details] [diff] [review]: ----------------------------------------------------------------- Looks straightforward. Thanks for the cleanup! ::: browser/components/nsBrowserGlue.js @@ +2391,5 @@ > var mainAction = popupNotificationActions.length ? > popupNotificationActions[0] : null; > var secondaryActions = popupNotificationActions.splice(1); > > + // Only allow exactly one permission request here. nit: There's the same typo in the "prompt" function, you may fix it while you're here.
Attachment #8606267 -
Flags: review?(paolo.mozmail) → review+
|
Assignee | |
Updated•9 years ago
|
Summary: Cleanup ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code → Clean up ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code
https://hg.mozilla.org/mozilla-central/rev/be648d3499bf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•