1165344 - The posted policy for performance regressions doesn't reflect reality

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

as discussed on dev.platform a few months ago:
https://groups.google.com/forum/#!searchin/mozilla.dev.platform/talos$20regression$20policy/mozilla.dev.platform/HkfaOTtAFVo/6L1E9GiOGGIJ

we should update our policy.

I am not very familiar with the wiki.m.o site, but let me submit a patch.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: perfpolicy_wiki.patch

I am not sure who to ask for review, let me assume someone will guide me through this.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this patch was developed using:
http://svn.mozilla.org/projects/mozilla.org/branches/staging/

ideally I would like to see it up there first, then land it on trunk:
http://svn.mozilla.org/projects/mozilla.org/trunk/

Comment 3

[Jennifer Bertsch [:jbertsch]]

Adding Gerv and Steven to review.

Comment 4

[Gervase Markham [:gerv]]

jbertsch: if you want someone to review something, set the review? flag, and give their email address. However, I don't think this particular policy is my responsibility...

Gerv

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

:jbertsch- do you know the next steps here?  We shouldn't have content as a policy online that doesn't match the current workflow.  I have no idea who is required to review the policy- I referenced a discussion on mozilla.dev.platform surrounding this policy.

Comment 6

[Jennifer Bertsch [:jbertsch]]

I guess if it is based on discussion and agreement in the forum we can just push it live?  Is there a module owner?

Maybe Kohei or Silver Orange could push it live?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

as a note, this patch was for staging- I wasn't sure if I messed anything up; I assume it would apply to production as well.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

this bug seems impossible to get traction on?  is there a policy for updating this wiki?  Anything else I could do?

Comment 9

[Gervase Markham [:gerv]]

This policy (as in, the idea of closing the tree for performance regressions) was originally a bit controversial back in 2002, which is why Mitchell is listed as the contact person and owner. But it has barely changed since then, according to the history. I think that today, the sheriffs either /de facto/ own the policy or know who does. I suggest you ask them, and whoever they say calls the tune that they dance to is the policy owner. That person can r= changes to the document, or (simpler) just ask for it to be removed. I suspect information about when and why we close the tree doesn't live on mozilla.org these days.

Gerv

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

we don't close trees for perf regressions; as it stands I am the only perf sheriff and want to get the policy we currently used on live documentation.

Comment 11

[Gervase Markham [:gerv]]

OK. If you are the bearer of the currently-agreed policy, then I think you should just go ahead and make the change. r=gerv.

Gerv

Comment 12

[Jennifer Bertsch [:jbertsch]]

Sorry this one has taken so long.

Let's get it live.

Kohei:  Do you have time to help?  Thanks!

Comment 13

[Kohei Yoshino [:kohei]]

Sure.

Comment 14

[Kohei Yoshino [:kohei]]

Oh the page is still on the SVN repo. I'm gonna move it to Bedrock then and update the content as suggested.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

:kohei, I know how svn commit access- not sure what bedrock is, is this something I should let you handle?

Comment 16

[Kohei Yoshino [:kohei]]

The current mozilla.org is a mixture of legacy PHP-based SVN repo and new Python-based Git repo. The new one is called Bedrock and we have to migrate all the content from the legacy repo to Bedrock within several months.

This page is on Bedrock:
https://www.mozilla.org/en-US/about/governance/policies/
https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/about/governance/policies/policies.html

This page is still on the legacy repo: 
https://www.mozilla.org/hacking/regression-policy.html
http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/hacking/regression-policy.html

Once we migrate the content, changes can be made with just a single GitHub pull request. That should be easier than SVN-based workflow :)

I'm happy to help moving the remaining 4 files on the /hacking/ directory to Bedrock, along with the changes proposed here.

# I have SVN access but only for l10n-related directories.

Comment 17

[Jennifer Bertsch [:jbertsch]]

Hi All-

Mike is going to file a blocker bug to migrate all the remaing /hacking files on SVN to Bedrock.

Thanks again for your patience,
Jen

Comment 18

[Kohei Yoshino [:kohei]]

Attachment: pull request

Filed Bug 1185070 for migration and sent a PR including this change.

Comment 19

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/6f7408a5e1b22d5d6b2cecad6914e3986b1badc3
Fix Bug 1165344 - The posted policy for performance regressions doesn't reflect reality

https://github.com/mozilla/bedrock/commit/183915232095a35077d9862ddd19bae4b984d7a8
Merge pull request #3136 from kyoshino/bug-1165344-regression-policy

Fix Bug 1165344 - The posted policy for performance regressions doesn't reflect reality

Comment 20

[Joel Maher ( :jmaher ) (UTC -8)]

the old policy is still here:
https://www.allizom.org/hacking/regression-policy.html

and here:
https://www.mozilla.org/hacking/regression-policy.html

I don't understand what Bedrock is, but do let me know what I can do to help out or resolve this myself.

Comment 21

[Kohei Yoshino [:kohei]]

The new page is not yet pushed to production by the team, but can be previewed on the staging site:

https://www-dev.allizom.org/hacking/regression-policy.html

The production push may happen today or tomorrow, so just hang on and be patient :)

Comment 22

[Kohei Yoshino [:kohei]]

Deployed. From now on, this page can be updated by sending a pull request for:

https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/about/governance/policies/regressions.html