1165353 - View pocket list should not appear in bookmark (button) menu(s) when the user is not logged in

Status: RESOLVED WONTFIX

(Firefox :: Menus, defect, P2)

Description

[:Gijs (he/him)]

Spun off from bug 1155519

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: bz://1165353/Gijs

/r/8831 - Bug 1165353 - don't show pocket menuitem in bookmarks panel/menu when not logged in, r?jaws

Pull down this commit:

hg pull -r 2f288a4d83106fc0cec6c25e4533cdf69455aebf https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Gijs (he/him)]

Meh, this was easier than I thought.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8606318 [details]
MozReview Request: bz://1165353/Gijs

https://reviewboard.mozilla.org/r/8829/#review7525

Ship It!

Comment 4

[Justin Dolske [:Dolske]]

P2 on this being potentially annoying UX for users, having a Pocket item for a service they're not using (even though it goes away if the button is disabled/removed, I assume lots of users won't bother).

However, I do recall some early product discussions wanting to keep these menuitems (making this bug a WONTFIX), as they're useful points where a user can see and use them to signup for a useful service. Not sure how much we considered the annoyance aspect with that, though.

Comment 5

[:Gijs (he/him)]

So, do you think this should land for 38.0.5 or not? If it does need to land, can you land it? I'm landing things now, but your last comment means I'm not sure if doing so here is the right thing.

Personally, I think it is, because "View Pocket List" is weird and we don't have time to update this to say something more sensible when you're not logged in. Thoughts?

Comment 6

[Justin Dolske [:Dolske]]

Product is ok with leaving this out of 38.0.5, and that we can revisit afterwards.

I don't want to leave an open bug with r+ patch in limbo, so let's call the WONTFIX, and we can reopen if direction changes.

Comment 7

[Justin Dolske [:Dolske]]

(Another option here is to change the string to "Sign up for Pocket", but that also can't make 38.0.5.)

Comment 8

[Nate Weiner]

After talking this over with the team we agree on making this a wontfix.

To clarify, the expected behavior is:
- If Pocket is enabled (ie in the menu), the View Pocket List entry should be viewable.
- If a user removes Pocket from the menu/toolbar, it should also remove the View Pocket List entry from the menu.

We absolutely want to avoid this being annoying for users who do not want the functionality, but the assumption is that those users will also be annoyed by the button in the toolbar and therefore would remove it, which removes all traces of Pocket. 

Having sub-states or hidden affordances can create user confusion (ex, if they somehow get logged out and then go look for their link to Pocket and can't find it).

Put more simply:
If the Pocket default state is active and then the pieces of Pocket should be on as well. Remove Pocket from Toolbar, then it should deactivate all pieces of Pocket as well.

Comment 11

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1165353 - don't show pocket menuitem in bookmarks panel/menu when not logged in, r?jaws