1165360 - (Windows hidpi) Dev Edition theme back button isn't showing the right icon, and the URL bar is too tall

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: windows-1.25-devedition.png

With the hidpi changes for windows in Bug 1147702, the styles in Dev Edition weren't synced up properly (see screenshot)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: deved-hidpi-WIP.patch

This updates the image region.  The height is still wrong even with this applied

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: windows-1x-icon.patch

We need to get a fix out to 40 ASAP for this.  My proposal is to just not try to do a 2x icon for those two.  I can handle actually switching to a working 2x version in a follow up

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7a8809f37feb

Comment 4

[Brian Grinstead [:bgrins]]

[Tracking Requested - why for this release]: This is breaking the layout for the Dev Edition theme in hidpi displays on Windows in 40

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8606564 [details] [diff] [review]
windows-1x-icon.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1147702
[User impact if declined]: Hidpi display on Windows with Dev Edition theme is broken
[Describe test coverage new/current, TreeHerder]: Visual change only
[Risks and why]: Low - the risk is lowered because it's isolated to the dev edition theme.  It changes the icons being displayed by the back and forward button back to what they used to be before Bug 1147702 landed
[String/UUID change made/needed]:

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7a8809f37feb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f8c8d7ef3321