Closed Bug 1165360 Opened 4 years ago Closed 4 years ago

(Windows hidpi) Dev Edition theme back button isn't showing the right icon, and the URL bar is too tall

Categories

(Firefox :: Theme, defect)

40 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox39 --- unaffected
firefox40 + fixed
firefox41 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(3 files)

With the hidpi changes for windows in Bug 1147702, the styles in Dev Edition weren't synced up properly (see screenshot)
This updates the image region.  The height is still wrong even with this applied
We need to get a fix out to 40 ASAP for this.  My proposal is to just not try to do a 2x icon for those two.  I can handle actually switching to a working 2x version in a follow up
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8606564 - Flags: review?(MattN+bmo)
Attachment #8606564 - Flags: review?(MattN+bmo) → review+
Whiteboard: [fixed-in-fx-team]
[Tracking Requested - why for this release]: This is breaking the layout for the Dev Edition theme in hidpi displays on Windows in 40
Comment on attachment 8606564 [details] [diff] [review]
windows-1x-icon.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1147702
[User impact if declined]: Hidpi display on Windows with Dev Edition theme is broken
[Describe test coverage new/current, TreeHerder]: Visual change only
[Risks and why]: Low - the risk is lowered because it's isolated to the dev edition theme.  It changes the icons being displayed by the back and forward button back to what they used to be before Bug 1147702 landed
[String/UUID change made/needed]:
Attachment #8606564 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7a8809f37feb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Attachment #8606564 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1166083
Depends on: 1192397
You need to log in before you can comment on or make changes to this bug.