Closed Bug 1165370 Opened 4 years ago Closed 4 years ago

Disable test_rocketbar_add_collection_save_bookmark.py until server-side issue are fixed

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

()

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8606343 [details] [review]
[gaia] mwargers:1165370 > mozilla-b2g:master

I don't know actually, if it's expected = random, if you expect sometimes the test to fail and sometimes not. Geo, do you perhaps know, where this is explained?
Attachment #8606343 - Flags: review?(gmealer)
Summary: Xfail test_rocketbar_add_collection_save_bookmark.py until server-side issue are fixed → Disable test_rocketbar_add_collection_save_bookmark.py until server-side issue are fixed
Ok, it turns out there is no disabled = random, we should just disable this test.
Comment on attachment 8606343 [details] [review]
[gaia] mwargers:1165370 > mozilla-b2g:master

Looks fine, though I have been putting the root bug in the manifest, not the bug for actually disabling the test. So in your case I'd have done:

disabled = Bug 1162112 - test_rocketbar_add_collection_save_bookmark.py: TimeoutException: TimeoutException: Timed out after 30.1 seconds

(I removed the quotes because they might mess with manifest format).

That said, it's not a big deal either way. Whether or not you decide to change the disabled reason, you don't need a re-review.
Attachment #8606343 - Flags: review?(gmealer) → review+
Ok, I changed it.

https://github.com/mozilla-b2g/gaia/commit/c2b1db33acfb43ccf3e5023569dce96f2cf901f7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.