Closed Bug 1165377 Opened 9 years ago Closed 9 years ago

[gui] change the color of the line in the report table view based on the verdict

Categories

(Testing :: mozregression, defect)

defect
Not set
normal

Tracking

(firefox41 affected)

RESOLVED FIXED
Tracking Status
firefox41 --- affected

People

(Reporter: parkouss, Assigned: jonathan.pigree)

Details

Attachments

(2 files)

196.11 KB, image/png
parkouss
: feedback+
Details
49 bytes, text/x-github-pull-request
parkouss
: review+
Details | Review
After some discussion on irc, Jonathan had the great idea to change the colors of the lines in the report table view, depending on the verdict.

Let's implement this!
Oh yeah. I am all pumped up. ;)
Attachment #8621174 - Flags: review?(j.parkouss)
Okay. This bug is easy actually. I implemented it. It really adds readability and is not too horrible.
Attached file PR
Attachment #8621200 - Flags: review?
Attachment #8621200 - Flags: review? → review?(j.parkouss)
Comment on attachment 8621174 [details]
POC for colors to show verdict

Yeah, seems good to me!
Attachment #8621174 - Flags: review?(j.parkouss) → feedback+
Comment on attachment 8621200 [details] [review]
PR

Looks good to me, thanks!

I just have a minor request on the PR to make the code more "pythonic". Once this is fixed I'll be happy to merge this in!
Attachment #8621200 - Flags: review?(j.parkouss) → review+
Okay. PR updated. Please review it when you have some time.
Yeah, mozregression looks nicer! Thanks Jonathan, I merged this in. :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: