[gui] change the color of the line in the report table view based on the verdict

RESOLVED FIXED

Status

Testing
mozregression
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: parkouss, Assigned: jonathan.pigree)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox41 affected)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
After some discussion on irc, Jonathan had the great idea to change the colors of the lines in the report table view, depending on the verdict.

Let's implement this!
(Assignee)

Comment 1

3 years ago
Oh yeah. I am all pumped up. ;)
(Assignee)

Comment 2

2 years ago
Created attachment 8621174 [details]
POC for colors to show verdict
Attachment #8621174 - Flags: review?(j.parkouss)
(Assignee)

Comment 3

2 years ago
Okay. This bug is easy actually. I implemented it. It really adds readability and is not too horrible.
(Assignee)

Comment 4

2 years ago
Created attachment 8621200 [details] [review]
PR
Attachment #8621200 - Flags: review?
(Assignee)

Updated

2 years ago
Attachment #8621200 - Flags: review? → review?(j.parkouss)
(Reporter)

Comment 5

2 years ago
Comment on attachment 8621174 [details]
POC for colors to show verdict

Yeah, seems good to me!
Attachment #8621174 - Flags: review?(j.parkouss) → feedback+
(Reporter)

Comment 6

2 years ago
Comment on attachment 8621200 [details] [review]
PR

Looks good to me, thanks!

I just have a minor request on the PR to make the code more "pythonic". Once this is fixed I'll be happy to merge this in!
Attachment #8621200 - Flags: review?(j.parkouss) → review+
(Assignee)

Comment 7

2 years ago
Okay. PR updated. Please review it when you have some time.
(Reporter)

Comment 8

2 years ago
Yeah, mozregression looks nicer! Thanks Jonathan, I merged this in. :)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.