Closed Bug 1165385 Opened 5 years ago Closed 5 years ago

Remove the non-full format option from MOZ_GCTIMER

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It adds non-zero complexity and it isn't terribly useful. At least, it doesn't add anything that a bit of grep and sed can't also add, and with tremendously more flexibility. At the very least, the totally different output mode should not alias the same environment variable -- for now I'm just going to remove it.
Attachment #8606375 - Flags: review?(sphink)
Blocks: 1164973
Comment on attachment 8606375 [details] [diff] [review]
cleanup_remove_fullFormat-v0.diff

Review of attachment 8606375 [details] [diff] [review]:
-----------------------------------------------------------------

Good call. The terse format didn't really bother me, but the weird dependence on the output location for which type of format you got was nasty. I had on my todo list to make them orthogonal, but you're right, there's no need for the terse format in the first place.
Attachment #8606375 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/de37ce76d3f5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.