Remove the non-full format option from MOZ_GCTIMER

RESOLVED FIXED in Firefox 41

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8606375 [details] [diff] [review]
cleanup_remove_fullFormat-v0.diff

It adds non-zero complexity and it isn't terribly useful. At least, it doesn't add anything that a bit of grep and sed can't also add, and with tremendously more flexibility. At the very least, the totally different output mode should not alias the same environment variable -- for now I'm just going to remove it.
Attachment #8606375 - Flags: review?(sphink)
(Assignee)

Updated

3 years ago
Blocks: 1164973
Comment on attachment 8606375 [details] [diff] [review]
cleanup_remove_fullFormat-v0.diff

Review of attachment 8606375 [details] [diff] [review]:
-----------------------------------------------------------------

Good call. The terse format didn't really bother me, but the weird dependence on the output location for which type of format you got was nasty. I had on my todo list to make them orthogonal, but you're right, there's no need for the terse format in the first place.
Attachment #8606375 - Flags: review?(sphink) → review+
(Assignee)

Comment 2

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc668b08e3e8

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/de37ce76d3f5
https://hg.mozilla.org/mozilla-central/rev/de37ce76d3f5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.